From: LM <lmemsm@gmail.com>
To: musl@lists.openwall.com
Subject: Re: musl setup attempt
Date: Sat, 16 Mar 2013 09:36:27 -0400 [thread overview]
Message-ID: <CAFipMOGDmOpv+W0-bbhJJ0WX6MSuQY80UBr_DNUvvRnzB9_1iQ@mail.gmail.com> (raw)
In-Reply-To: <20130315141141.1f14e6a4.idunham@lavabit.com>
On 3/15/13, Isaac Dunham <idunham@lavabit.com> wrote:
> A few points:
> 1) Patches beat bug reports. Make sure that you note upstream policy about
> copyright assignments and so on, though.
> Also follow the code style upstream uses.
> 2) Make sure it's not going to break upstream policy.
> Examples: don't change -std=c89
> 3) Make sure it doesn't disable something for other platforms (eg, breaking
> tests for uclibc)
> 4) Make it as little change as appropriate
> 5) If at all possible, test on other platforms.
Thanks for the points. It's good to know I'm on the right track. I
do all of those things. I do typically provide patches with my bug
reports. To me, there's usually no point in saying it's broken if I
can't give a fix for it.
> The best response I had was a trivial patch for libnl (adding a couple
> headers) which I prepared, tested on musl and glibc, then sent with a
> comment that it fixed build on musl and worked on glibc. It was applied
> almost immediately.
I've had lots of patches added to software. I've also had lots of
uncomfortable results where the developers were not very polite (and
this seems to be happening a lot more often in recent years than it
did years ago when I first started doing this). If you know the
phrase, one bad apples spoils the whole bunch, well that certainly
applies for me. It's made me rather uncomfortable every time I send
in a patch now and I often think twice before doing so. I'm not sure
if someone's going to want it or if they're going to be nasty about
it. I even preface some of my messages now by saying in case you'd
like to support this platform, here's what I had to do to get your
software to compile successfully on this system.
Sincerely,
Laura
next prev parent reply other threads:[~2013-03-16 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 11:54 LM
2013-03-13 14:07 ` Isaac Dunham
2013-03-13 18:49 ` John Spencer
2013-03-15 11:54 ` LM
2013-03-15 21:11 ` Isaac Dunham
2013-03-16 13:36 ` LM [this message]
2013-03-16 22:58 ` Rich Felker
2013-03-14 11:02 LM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFipMOGDmOpv+W0-bbhJJ0WX6MSuQY80UBr_DNUvvRnzB9_1iQ@mail.gmail.com \
--to=lmemsm@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).