From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26005 invoked from network); 23 Jan 2021 12:33:32 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 23 Jan 2021 12:33:32 -0000 Received: (qmail 17520 invoked by uid 550); 23 Jan 2021 12:33:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 13972 invoked from network); 23 Jan 2021 06:47:24 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=AbARmVF5U6DXe32MhnhkVcBwjB2+jVf53bQZDXIGie0=; b=RgVblWpLEVOjUxAgrQ1ec+Ve22oOgMFd+w1631o1qouZKWHk/bK2fZwwndzYw+lbur XQO3nGtfgMkqPlUJXqmXXXCYv3cDY6NXX1QNt6Riv5TbsjBVLytFkicj9VF7frARpU4Y W6+h8pfCBEma/JiFyJVduO7RuwTTP8V+dPdszN5HLekbnySmzpnHAHnQLF9rUHtfCCJn ZYfTC5ZKicGrOnx17lsvZuMsikLAXWpvca9/AbDdxFIqB1CLc8GyNgp+qsRmSlQAWTQR CLaqZtfsw4GQVFGtDoGC72xiJE1OAqwqFyp9pgCCtMEjWGHnSz15mz0CKppD28R3ajRU pGmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=AbARmVF5U6DXe32MhnhkVcBwjB2+jVf53bQZDXIGie0=; b=PYBlb4C3HGdVSgTViZKhP+R3NDZ4xhvHBUZ/twcqUCTrtvmS2f8lZUGV2OrmJ4SRo+ +jfr0i20VjFqlORKzykFWCPT9nDhDNfc/ZSGAp+O9zDcBednGU5/4NnjM0B46uWL8cRk IZ4fvfw2D5h+6p7IhYU8I3p+9DIiVdGD3rFwoWo3B3Fjiqih1Wx5/U9gRSq0AL3ZRVnS wmp2zJiMFiMT8YzSVRi7H/WXt9e93rFReYpwSLQuNsRswAX7ayIG6+nzzpiqGhvwE4qN 6QrZHsJoS9QwY5KIAtBMNI87w2mfiaf5LpD7sWa2hBosQkBAiwBQrFhvI4THjLCS6jwH g8Fw== X-Gm-Message-State: AOAM532SKt8gR/dA0ZfYAIlM64W3JtEcPCHAyAqv5MpI4IKa25zpaxpE yU8MkotWG/mQeUPDISvumfOOlmPjxYk0XFSJzGwNNVpZor/wXw== X-Google-Smtp-Source: ABdhPJxmWLHccBVyPqPgTg51UjFa5dt33W7A4Br73vcEXG6oBpnqV/baInzWDOc0d8VfqSjJAna1BH242SqpPTPVYts= X-Received: by 2002:a2e:6e11:: with SMTP id j17mr299258ljc.337.1611384431732; Fri, 22 Jan 2021 22:47:11 -0800 (PST) MIME-Version: 1.0 From: Andrew Rogers Date: Sat, 23 Jan 2021 06:47:00 +0000 Message-ID: To: musl@lists.openwall.com Content-Type: multipart/mixed; boundary="000000000000a67cdf05b98bac78" Subject: [musl] Potential DL_NOMMU_SUPPORT bug. --000000000000a67cdf05b98bac78 Content-Type: multipart/alternative; boundary="000000000000a67cdd05b98bac76" --000000000000a67cdd05b98bac76 Content-Type: text/plain; charset="UTF-8" Hi, I was trying a DL_NOMMU_SUPPORT build so I could load binaries from the sdcard on an android device. I managed to succeed but only after making a mod which I later realised might apply beyond my application. The mmap_fixed() function would return as if successful even when mmap() call had failed Hopefully the link and the patch below help. Regards Andrew https://git.musl-libc.org/cgit/musl/tree/ldso/dynlink.c?id=85e0e3519655220688e757b9d5bfd314923548bd#n584 diff -Naur musl-1.2.2-orig/ldso/dynlink.c musl-1.2.2-new/ldso/dynlink.c --- musl-1.2.2-orig/ldso/dynlink.c 2021-01-15 02:26:00.000000000 +0000 +++ musl-1.2.2-new/ldso/dynlink.c 2021-01-23 06:26:26.861158169 +0000 @@ -581,7 +581,7 @@ char *q; if (!no_map_fixed) { q = mmap(p, n, prot, flags|MAP_FIXED, fd, off); - if (!DL_NOMMU_SUPPORT || q != MAP_FAILED || errno != EINVAL) + if (!DL_NOMMU_SUPPORT && q != MAP_FAILED && errno != EINVAL) return q; no_map_fixed = 1; } --000000000000a67cdd05b98bac76 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I was trying a DL_NOMMU_= SUPPORT build so I could load binaries from the sdcard on an android device= . I managed to succeed but only after making a mod which I later realised m= ight apply beyond my application.

The mmap_fixed()= function would return as if successful even when mmap() call had failed

Hopefully the link and the patch below help.

Regards
Andrew


--000000000000a67cdd05b98bac76-- --000000000000a67cdf05b98bac78 Content-Type: text/x-patch; charset="US-ASCII"; name="musl-DL_NOMMU_SUPPORT-dynlink.patch" Content-Disposition: attachment; filename="musl-DL_NOMMU_SUPPORT-dynlink.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kk9cndty0 ZGlmZiAtTmF1ciBtdXNsLTEuMi4yLW9yaWcvbGRzby9keW5saW5rLmMgbXVzbC0xLjIuMi1uZXcv bGRzby9keW5saW5rLmMKLS0tIG11c2wtMS4yLjItb3JpZy9sZHNvL2R5bmxpbmsuYwkyMDIxLTAx LTE1IDAyOjI2OjAwLjAwMDAwMDAwMCArMDAwMAorKysgbXVzbC0xLjIuMi1uZXcvbGRzby9keW5s aW5rLmMJMjAyMS0wMS0yMyAwNjoyNjoyNi44NjExNTgxNjkgKzAwMDAKQEAgLTU4MSw3ICs1ODEs NyBAQAogCWNoYXIgKnE7CiAJaWYgKCFub19tYXBfZml4ZWQpIHsKIAkJcSA9IG1tYXAocCwgbiwg cHJvdCwgZmxhZ3N8TUFQX0ZJWEVELCBmZCwgb2ZmKTsKLQkJaWYgKCFETF9OT01NVV9TVVBQT1JU IHx8IHEgIT0gTUFQX0ZBSUxFRCB8fCBlcnJubyAhPSBFSU5WQUwpCisJCWlmICghRExfTk9NTVVf U1VQUE9SVCAmJiBxICE9IE1BUF9GQUlMRUQgJiYgZXJybm8gIT0gRUlOVkFMKQogCQkJcmV0dXJu IHE7CiAJCW5vX21hcF9maXhlZCA9IDE7CiAJfQo= --000000000000a67cdf05b98bac78--