mailing list of musl libc
 help / color / mirror / code / Atom feed
From: John Mudd <johnbmudd@gmail.com>
To: Rich Felker <dalias@libc.org>
Cc: musl <musl@lists.openwall.com>
Subject: Re: ERROR: epoll_create1 failed: Function not implemented ?
Date: Tue, 26 Jun 2018 17:59:48 -0400	[thread overview]
Message-ID: <CAGDMk9E1Fg8N7Df5GsLMWgvkExPOQf8Ftz_7GUmy=NdctDGT6w@mail.gmail.com> (raw)
In-Reply-To: <20180626141434.GU1392@brightrain.aerifal.cx>

[-- Attachment #1: Type: text/plain, Size: 3079 bytes --]

Thanks, I was able to turn off use of epoll. Here part of my script. I
added  -UHAVE_SYS_EPOLL_H option and removed HAVE_SYS_EPOLL_H from
the pg_config.h file.

    JOPT=-j6
    POSTGRES=10.3
    cd $BUILD_DIR
    . update
    rm -rf postgresql*
    wget
https://ftp.postgresql.org/pub/source/v$POSTGRES/postgresql-$POSTGRES.tar.bz2
    tar xf postgresql*.tar.*
    cd postgresql-$POSTGRES
    ./configure \
        --prefix=$(pwd).install \
        --with-python \
        --with-openssl \
        --with-libxml \
        --with-libxslt \
        --with-includes="$(ls -d ../openssl-*.install/include)" \
        LDFLAGS="-ltinfo -lncurses" CFLAGS='-UHAVE_POSIX_FALLOCATE
-UHAVE_SYS_EPOLL_H' && \
    sed -i "/HAVE_POSIX_FALLOC/d"
$BUILD_DIR/postgresql-$POSTGRES/src/include/pg_config.h && \
    sed -i "/HAVE_SYS_EPOLL_H/d"
$BUILD_DIR/postgresql-$POSTGRES/src/include/pg_config.h && \
    make $JOPT world

On Tue, Jun 26, 2018 at 10:14 AM Rich Felker <dalias@libc.org> wrote:

> On Tue, Jun 26, 2018 at 01:46:15AM +0200, Szabolcs Nagy wrote:
> > * John Mudd <johnbmudd@gmail.com> [2018-06-25 16:49:36 -0400]:
> > > I build a dynamically linked version of Postgres using musl. It's been
> > > working well for years. I just built a new version and I'm getting the
> > > following Postgres error on some machines. Any suggestions?
> > >
> > >     ERROR:  epoll_create1 failed: Function not implemented
> > >
> >
> > try to run it with strace to see how epoll_create1 is called
> >
> > > I build on 32-bit Linux Mint 18.3 Sylvia with 4.13.0-39-generic kernel.
> > >
> > > It runs on some machines such as 64-bit Ubuntu with 4.4.0-121-generic
> > > kernel. But fails on CentOS release 5.4 (Final) with 2.6.18-416.el5 #1
> SMP
> > > kernel.
> > >
> > > My previous musl builds of Postgres run on all of my machines.
>
> Linux 2.6.18 did not have the SYS_epoll_create1 syscall; it was added
> in 2.6.27 (according to man 2 syscalls) which is around the time all
> the O_CLOEXEC-family stuff was added. I suspect the new version of
> Postgres you updated too is (correctly) passing the EPOLL_CLOEXEC flag
> to make opening the epoll fd safe against fd leak races, and there is
> fundamentally (well, without horrible hacks) no way to emulate this on
> old kernels that lack the functionality.
>
> For some other interfaces we emulate the functionality non-atomically
> with fcntl after the open, but this isn't really a good solution.
>
> Really you should update the kernel to something capable of dealing
> safely with fd-leak races. For correct behavior of many interfaces,
> musl needs a minimum kernel version of around 2.6.28; behavior with
> earlier versions will be best-effort.
>
> If you really can't upgrade the kernel, consider patching Postgres to
> remove the EPOLL_CLOEXEC flag (pass 0 for the flag) and possibly
> adding a fcntl call to set the O_CLOEXEC flag after epoll_create[1]
> succeeds. Or you can see if there's an option to build without epoll
> at all, using the standard poll instead which does not use a fd and is
> not affected by this issue.
>
> Rich
>

[-- Attachment #2: Type: text/html, Size: 4067 bytes --]

      reply	other threads:[~2018-06-26 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 20:49 John Mudd
2018-06-25 23:46 ` Szabolcs Nagy
2018-06-26 14:14   ` Rich Felker
2018-06-26 21:59     ` John Mudd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGDMk9E1Fg8N7Df5GsLMWgvkExPOQf8Ftz_7GUmy=NdctDGT6w@mail.gmail.com' \
    --to=johnbmudd@gmail.com \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).