From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13755 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Forney Newsgroups: gmane.linux.lib.musl.general Subject: Re: [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc Date: Sun, 10 Feb 2019 11:27:21 -0800 Message-ID: References: <20181106063655.12357-1-mforney@mforney.org> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="192432"; mail-complaints-to="usenet@blaine.gmane.org" To: musl@lists.openwall.com Original-X-From: musl-return-13771-gllmg-musl=m.gmane.org@lists.openwall.com Sun Feb 10 20:27:37 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1gsulN-000nyK-5F for gllmg-musl@m.gmane.org; Sun, 10 Feb 2019 20:27:37 +0100 Original-Received: (qmail 12233 invoked by uid 550); 10 Feb 2019 19:27:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 12199 invoked from network); 10 Feb 2019 19:27:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mforney-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=oFrhxgvP+OuikYXdbW9WVfthqeK8ZcT1zn3e1au1FsI=; b=cfngdcK9wlxcKc7LHUlo2hutx1uhF35HMbAjokV1ejsU/ENDvTsdLxc6C1oK4Zwlsa u0uhhJ6qMBDpmUdpHVPmkc4jrSBGCR18lWU6aZYjIB7Acfz4bZrkfsAmnVhZizH4zsSL X2mj7yuKokEGcuOYczwF02ICTrwX+lu/+YsTGViktPaxI0qiDlpt3ptAiBm7/w/n6qr4 PVzBeEtWJNa9H7tJikfx0d95ao8M86+OmuAgT3Y6JLAOKIyIoCDJdJGDLpRDsSvjMmId mAJ3riwf93RQJiv7J06Mxy+twWmc2cQlwiYlwAOCu1SB47VTzxFJJbghLXDNYvsFDBrT WEyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=oFrhxgvP+OuikYXdbW9WVfthqeK8ZcT1zn3e1au1FsI=; b=c4hz840FHaS3qrvXuHAO/JWEH7h+Io+AQyfJpy26fS0q8vupcDZiTNGrqpJiQkjZ8G q5KM4w3Y+WvxumJvq/jkLozHsGkM+7grc5+6vKmIrpjUbFcjejyNXKTUX3IpodfMjhbU NhnvGITTFEQb0wTpocR5rsBIXWx1J2goTpjloMmAKUmfRk2aTjxEonYLLvwczN7FLzwV DpfA0NJUmvbr7wgA+bTfX4L3c7KWrQPQfjQAv5Ls2eiISEEcJUpWPnpIKJEp4Ma3Vb/v ZGVz0rD49duY9DtGyP/EKLnTKlJp5W6I3gKvaXK3TGYJWthUiJkZNYbRfrlYpxvrJvNj 7aWg== X-Gm-Message-State: AHQUAubgOpZ8C5UQhIM8XaQDFgAgn2wUHzke57PtH3xq1Iq+W0gI2uUs 480YgaOJAZuBTFLiwbk+VtrNnFM3TlZlAvCX9esCHx6+lV0= X-Google-Smtp-Source: AHgI3IbST+O0vUxu2xs3Mz45xKfZXiOXTzVmZT/Hvil5l0vgbj73KKhv7e+r5lJRSWRVj3eAQxxmJVN4Uhh5nt4DGvE= X-Received: by 2002:a25:2d65:: with SMTP id s37mr23018478ybe.110.1549826841755; Sun, 10 Feb 2019 11:27:21 -0800 (PST) X-Originating-IP: [2601:647:5180:35d7::8814] In-Reply-To: <20181106063655.12357-1-mforney@mforney.org> Xref: news.gmane.org gmane.linux.lib.musl.general:13755 Archived-At: On 2018-11-05, Michael Forney wrote: > When the gcc and binutils build trees were separated in defdbb4505, > --enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG. > This had the effect of reverting commit e83fe4b8ce, breaking > reproducible builds (unless it was specified explicitly in config.mak). > --- > litecross/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/litecross/Makefile b/litecross/Makefile > index 2f78157..4ecfa93 100644 > --- a/litecross/Makefile > +++ b/litecross/Makefile > @@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \ > --disable-werror \ > --target=$(TARGET) --prefix= \ > --libdir=/lib --disable-multilib \ > - --with-sysroot=$(SYSROOT) > + --with-sysroot=$(SYSROOT) \ > + --enable-deterministic-archives > > FULL_GCC_CONFIG = --enable-languages=c,c++ \ > $(GCC_CONFIG_FOR_TARGET) \ > @@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \ > --disable-libmudflap --disable-libsanitizer \ > --disable-gnu-indirect-function \ > --disable-libmpx \ > - --enable-deterministic-archives \ > --enable-libstdcxx-time > > FULL_MUSL_CONFIG = $(MUSL_CONFIG) \ > -- > 2.19.1 Ping. I think this patch should be pretty uncontroversial. It is a simple fix for a regression introduced in defdbb4505. Would you prefer a github pull request instead?