mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Michael Forney <mforney@mforney.org>
To: musl@lists.openwall.com
Cc: "Érico Nogueira" <ericonr@disroot.org>
Subject: Re: [musl] [PATCH] add pthread_getname_np function
Date: Fri, 9 Jul 2021 01:06:51 -0700	[thread overview]
Message-ID: <CAGw6cBvkazTMyH8FA8nnF4aFzWXh31CYBU8+jQt7RsWRVFXWxg@mail.gmail.com> (raw)
In-Reply-To: <20210420191519.23822-1-ericonr@disroot.org>

On 2021-04-20, Érico Nogueira <ericonr@disroot.org> wrote:
> +	if ((fd = open(f, O_RDONLY|O_CLOEXEC)) < 0 || (len = read(fd, name, len)) < 0) status = errno;

This read error check isn't quite right. len has type size_t (which is
unsigned), so (len = ...) < 0 is always false. I think you probably
need to use a separate variable here.

  parent reply	other threads:[~2021-07-09  8:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 19:15 Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH v2] define __STDC_UTF_{16,32}__ macros Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH] extend gethostid beyond a stub Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH] remove unnecessary cast for map_library return Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH] shorten __aeabi_memset by one instruction Érico Nogueira
2021-04-21  8:24   ` Szabolcs Nagy
2021-04-21 12:32     ` Jesse DeGuire
2021-04-21 17:38     ` Rich Felker
2021-04-21 19:02       ` Érico Nogueira
2021-05-20 13:04 ` [musl] [PATCH] add pthread_getname_np function Stefan Agner
2021-07-09  8:06 ` Michael Forney [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-25 20:19 Érico Nogueira
2020-12-19 18:37 Érico Nogueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGw6cBvkazTMyH8FA8nnF4aFzWXh31CYBU8+jQt7RsWRVFXWxg@mail.gmail.com \
    --to=mforney@mforney.org \
    --cc=ericonr@disroot.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).