From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1939 invoked from network); 21 Feb 2023 19:45:55 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 21 Feb 2023 19:45:55 -0000 Received: (qmail 20170 invoked by uid 550); 21 Feb 2023 19:45:52 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 20135 invoked from network); 21 Feb 2023 19:45:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dfDtuNixkNFJ4VNASJxc8FyTg9udnl+YAaE0qTAmMEM=; b=gSy9OvGUUpjrZ56tHAAEPho4qC+biNRs6gobcP6M5IxxycPPiFIiDsN+dfcQerJouA nQ0eCLgXyQ12wejDF2AgVmCEgzx3qd7y0HNHm7t001E4aGrEBSHndzYC10EPgKboR10v G7LWDcVQaXbI69/gntKWVGT5ZafWDz98iWIYr9iNiAELfxA8dRp0C0tAmMIvqXc+dDRU jXb7jnoPF5hOBYwVxoxoT4noA0H7LixEmm0tgQnc9Jf0lGLMc6nMGy0OLqvm0L20LvZ8 FF8tj9c/F54Yf6m/ol4XIcCr8+SUs+r+jpn6gfbhYGpqLy8exErqCzWNh51sZ9KUuMz6 W59Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dfDtuNixkNFJ4VNASJxc8FyTg9udnl+YAaE0qTAmMEM=; b=RMePBs60a5AYOX0M7eewCaIYh326Nkr/9gwgqfxPKRlS/Hdm3VERI6uZm1qeYiui3g 5KyNaSiQ5ftg9I2aKlwtfYcsLo2kyHSGqccvlTYxFJDqZxBO/TNydwGQLaj1Q+b4eNcp zGCPGt5yJDVL9SaM0ZE69etJLfhWryei3ntbXq4A2enPqrbmqamES6h9BpAUqB0zcRGs HdjnwY3WubvmsPQxZAbgbhPdpIIpGGAM5Z/yHNOY5tiXpLCTiAsQhOrjPUVpKdNH2pyt 3oNa0qbbl0Hc4GOvPci6t56plMKa9A2SRclutPRacYitaS64xY4cVNW8HmjeeVQ8a/68 s7/A== X-Gm-Message-State: AO0yUKUI2plHdnwYRfTJTWXZWBHOgo8ATczrFv+Uj5jZj8o+6KKbqQI1 1ctMvQ79eIAMDRUF2EjCx2eA1NtwoTtQP7g7/wETA85E X-Google-Smtp-Source: AK7set9xvXp0/cbPvMLPqnAPddxy9zGgYD6K2LvbQOq3sH2F6pDXFmyTcxO9UqbQBr5VGsdxZnBwzuqOXU+NwNURYec= X-Received: by 2002:a05:6808:1484:b0:37f:af31:1f9a with SMTP id e4-20020a056808148400b0037faf311f9amr1074032oiw.181.1677008739248; Tue, 21 Feb 2023 11:45:39 -0800 (PST) MIME-Version: 1.0 References: <20230218013333.844224-1-i@maskray.me> <20230218020320.GA4163@brightrain.aerifal.cx> In-Reply-To: From: Jeffrey Walton Date: Tue, 21 Feb 2023 14:45:28 -0500 Message-ID: To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [musl] [PATCH] Use __builtin_FILE/__builtin_LINE if available On Sat, Feb 18, 2023 at 7:17 AM Jon Chesterfield wrote: > > On Sat, 18 Feb 2023, 02:54 Fangrui Song, wrote: > > On Fri, Feb 17, 2023 at 6:03 PM Rich Felker wrote: > > > > On Fri, Feb 17, 2023 at 05:33:33PM -0800, Fangrui Song wrote: > > > C++ inline functions are requred to have exact same sequence of tokens > > > in every translation unit, but __FILE__ and __LINE__ may expand to > > > different tokens. The ODR violatioin is usually benign, but it can lead > > > to errors when C++20 modules are used. > > It is sad that C++ modules broke 'assert' but not surprising. Modules were largely created out of aversion to macros. This isn't something libc can fix though, I suggest a defect report against C++ instead. Somewhat related, I tried contacting the C/C++ committee to have concerns addressed several years ago. I was not able to reach the committee. There's no mailing list or discussion group available to the public at large. It looks like one of those groups where the committee only talks with the companies that build compilers. Outsiders (like compiler users) are not welcomed. > Changing the semantics of assert in C seems like a bad thing to do. ++ Jeff