From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Rich Felker <dalias@aerifal.cx>
Cc: libc-alpha <libc-alpha@sourceware.org>, musl@lists.openwall.com
Subject: Re: O_EXEC and O_SEARCH
Date: Sat, 23 Feb 2013 00:20:58 -0500 [thread overview]
Message-ID: <CAHGf_=p72+wjc_2L4=CQ-qZqt8utPKPqbg=PMOkE2rokDOxrUw@mail.gmail.com> (raw)
In-Reply-To: <20130223050323.GW20323@brightrain.aerifal.cx>
On Sat, Feb 23, 2013 at 12:03 AM, Rich Felker <dalias@aerifal.cx> wrote:
> On Fri, Feb 22, 2013 at 11:54:17PM -0500, KOSAKI Motohiro wrote:
>> > Right now, we're offering O_EXEC and O_SEARCH in musl libc, defining
>> > them as O_PATH. As long as recent Linux is used, this gives nearly
>> > correct semantics, except that combined with O_NOFOLLOW they do not
>> > fail when the final component is a symbolic link. I believe it's
>> > possible to work around this issue on sufficiently modern kernels
>> > where fstat works on O_PATH file descriptors, but adding the
>> > workaround whenever O_PATH|O_NOFOLLOW is in the flags would change the
>> > semantics when O_PATH is used by the caller rather than O_EXEC or
>> > O_SEARCH, since the value is equal. I'm not sure this is desirable.
>>
>> I have one more question. If I understand correctly, O_NOFOLLOW is
>> unspecified in
>> POSIX.
>
> Wrong.
>
>> Why do you think the current behavior is not correct?
>
> O_NOFOLLOW
> If path names a symbolic link, fail and set errno to [ELOOP].
>
> See http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html
ok. this is linux kernel man pages mistake.
http://man7.org/linux/man-pages/man2/open.2.html
> O_NOFOLLOW
> If pathname is a symbolic link, then the open fails. This is a
> FreeBSD extension, which was added to Linux in version 2.1.126.
> Symbolic links in earlier components of the pathname will still be
> followed.
>> And, as far as I observed, current linux man pages don't tell us
>> O_PATH|O_NOFOLLOW
>> behavior. Is this really intentional result? How do you confirmed?
>
> Yes, it seems intentional. O_PATH without O_NOFOLLOW would resolve the
> symbolic link and open a file descriptor referring to the target
> inode. O_PATH|O_NOFOLLOW opens a file descriptor to the symbolic link
> inode itself. As far as I can see, this behavior is desirable and
> intentional with O_PATH but wrong for O_SEARCH or O_EXEC.
Hmm... Why?
It doesn't match linux man nor posix.
next prev parent reply other threads:[~2013-02-23 5:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 0:45 Rich Felker
2013-02-23 3:05 ` KOSAKI Motohiro
2013-02-23 3:17 ` Rich Felker
2013-02-23 3:58 ` KOSAKI Motohiro
2013-02-23 4:33 ` Rich Felker
2013-02-23 5:01 ` KOSAKI Motohiro
2013-02-23 5:05 ` Rich Felker
2013-02-23 5:21 ` KOSAKI Motohiro
2013-02-23 4:54 ` KOSAKI Motohiro
2013-02-23 5:03 ` Rich Felker
2013-02-23 5:20 ` KOSAKI Motohiro [this message]
2013-02-23 5:28 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGf_=p72+wjc_2L4=CQ-qZqt8utPKPqbg=PMOkE2rokDOxrUw@mail.gmail.com' \
--to=kosaki.motohiro@gmail.com \
--cc=dalias@aerifal.cx \
--cc=libc-alpha@sourceware.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).