From: Ben Noordhuis <info@bnoordhuis.nl>
To: musl@lists.openwall.com
Subject: Re: [musl] Re: [PATCH] add statx
Date: Tue, 28 Jan 2020 09:59:56 +0100 [thread overview]
Message-ID: <CAHQurc-tefnmXxv7r72DLs2MN46aceC9YJi=Fvnzs6bVtZt30A@mail.gmail.com> (raw)
In-Reply-To: <20200124140113.GU30412@brightrain.aerifal.cx>
On Fri, Jan 24, 2020 at 3:01 PM Rich Felker <dalias@libc.org> wrote:
>
> On Fri, Jan 24, 2020 at 09:38:49AM +0100, Ben Noordhuis wrote:
> >
> > Can I get some feedback on this patch, even if it's just "no because"? Thanks.
>
> Sorry aboout that; I'd just had my mind on other things and hadn't
> taken the time to make a good review yet.
Thanks for the feedback and no worries, I'm no saint in that regard either.
Before I post a v2, did I understand the following issues correctly?
1. Switch _GNU_SOURCE || _BSD_SOURCE -> just _GNU_SOURCE? FWIW,
_BSD_SOURCE currently exposes the AT_STATX_* flags in fcntl.h.
2. uint64_t -> unsigned long long guarded by #ifdef __GNUC__
__extension__? Or just leave it as-is?
4. An ENOSYS fallback to fstatat()? glibc's fallback returns EINVAL
for AT_* flags it doesn't understand and ignores all STATX_* flags: it
sets stx_mask to STATX_BASIC_STATS, fills in stx_uid/stx_gid/etc. and
sets stx_btime to zero. Does that sound reasonable?
next prev parent reply other threads:[~2020-01-28 9:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:12 [musl] " Ben Noordhuis
2020-01-24 8:38 ` [musl] " Ben Noordhuis
2020-01-24 14:01 ` Rich Felker
2020-01-28 8:59 ` Ben Noordhuis [this message]
2020-01-28 13:39 ` Rich Felker
2020-01-24 14:00 ` [musl] " Rich Felker
2020-01-24 15:27 ` Florian Weimer
2020-01-24 15:54 ` Rich Felker
2020-01-24 16:12 ` Florian Weimer
2020-01-24 16:29 ` Rich Felker
2020-01-28 10:41 ` Florian Weimer
2020-01-28 13:18 ` Rich Felker
2020-02-17 9:10 ` Florian Weimer
2020-02-17 15:29 ` Rich Felker
2022-08-27 14:57 ` [musl] [PATCH 0/1] " Duncan Bellamy
2022-08-27 14:57 ` [musl] [PATCH 1/1] resubmitting old statx patch with changes Duncan Bellamy
2022-08-27 18:10 ` Rich Felker
2022-08-27 23:11 ` Dunk
2022-08-27 23:11 ` [musl] [PATCH 0/2] V2 Duncan Bellamy
2022-08-27 23:11 ` [musl] [PATCH 1/2] V2 resubmitting old statx patch with changes Duncan Bellamy
2022-08-29 13:50 ` [musl] " Dunk
2022-08-27 23:11 ` [musl] [PATCH 2/2] V2 src/stat/fstatat.c use new statx define Duncan Bellamy
2022-08-31 19:07 ` [musl] [PATCH 0/2] V3 Duncan Bellamy
2022-08-31 19:07 ` [musl] [PATCH 1/2] V3 resubmitting old statx patch with changes Duncan Bellamy
2024-02-24 16:56 ` Rich Felker
2022-08-31 19:07 ` [musl] [PATCH 2/2] V3 src/stat/fstatat.c use new statx define Duncan Bellamy
2024-02-24 16:57 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQurc-tefnmXxv7r72DLs2MN46aceC9YJi=Fvnzs6bVtZt30A@mail.gmail.com' \
--to=info@bnoordhuis.nl \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).