From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by inbox.vuxu.org (OpenSMTPD) with SMTP id 5442595e for ; Tue, 28 Jan 2020 09:00:21 +0000 (UTC) Received: (qmail 27919 invoked by uid 550); 28 Jan 2020 09:00:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 27901 invoked from network); 28 Jan 2020 09:00:19 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bnoordhuis-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=O+WFFeT8akfvVSpom4ZFU1JqQlJpFJy0zqDAdgcz6FQ=; b=WZBkoqw6g/wjSuwt3yBwPE8EcTTDJC2gF4kLphHEPG+utZCpjYX7Pkh1RWkAM30r5v Cx34LnlZwZREP9vsL0v5QuzLUqQjv/zzyYWSeU+xnrxd7NT33+iE+kufJa9kEw5dXy7M Ode21biFOieNBWeiha0HTY7cLjBbyejFq50Oo54kTb6ieNRGWNnQ+19u+ndxt8yI8Rq2 V20arMfnlR5enLXN+cUxLYISz7uxEF9DQhBAUm4f+tJXb3cKL/+bqV9wh88unyVJAaMt Z0TOQtu7OugVRoURxjuSXhX2NbOGf9/spC8x/NaL6WhVOls8Ys97WF8JRBFglLHIISu+ g/vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=O+WFFeT8akfvVSpom4ZFU1JqQlJpFJy0zqDAdgcz6FQ=; b=M+vqQ47H9TbYdqsn74AVMiJ/smqBHaSwvImowzp4U8sbVoO1VWrHJOaXf/O6022CTG OLbMIIiqaDVgk3wVmdkuN7koMIhaf0VntrpI0rS835Vlfwuuxwk3qX+z40MGsfWjJ2su w34/AxX/h5Nttxd9UcIGxbwPhv/X9LdxF/lurH/qWVCEKq2A2ovG7ck/wZuELRUWRLpK /8J5iAvUMgtdRJd9ws/zQ0YIrgY3m3K++AWxOoj6v6fxDHArZOC95lcXLWkIQz49sESn EGUy5I0gfqYvyyRd0BXliT/jzGzk6SUo7AFsYUH/L5WQ7JMLAuxVTj+XY2FX8ywnw3Ci qehQ== X-Gm-Message-State: APjAAAXmnW1I3dEV1hthedLetGAEb4mqjOwfNtpjKFOFWGypmQNDf/0r ijfg2h2CRB3iMemklKdB1s1TdBvm0SGcOcpxINcB2XnD X-Google-Smtp-Source: APXvYqyQ2ZuHLtRLHkXxzLR0LsYHAJ8TNV7k1Q9GoEKx9bvpzycrEtghNjT8OaHZTyCleSDCIWB1iaGYvAw0aBqHuhE= X-Received: by 2002:aca:3017:: with SMTP id w23mr2066117oiw.152.1580202007476; Tue, 28 Jan 2020 01:00:07 -0800 (PST) MIME-Version: 1.0 References: <20200119121247.37310-1-info@bnoordhuis.nl> <20200124140113.GU30412@brightrain.aerifal.cx> In-Reply-To: <20200124140113.GU30412@brightrain.aerifal.cx> From: Ben Noordhuis Date: Tue, 28 Jan 2020 09:59:56 +0100 Message-ID: To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [musl] Re: [PATCH] add statx On Fri, Jan 24, 2020 at 3:01 PM Rich Felker wrote: > > On Fri, Jan 24, 2020 at 09:38:49AM +0100, Ben Noordhuis wrote: > > > > Can I get some feedback on this patch, even if it's just "no because"? Thanks. > > Sorry aboout that; I'd just had my mind on other things and hadn't > taken the time to make a good review yet. Thanks for the feedback and no worries, I'm no saint in that regard either. Before I post a v2, did I understand the following issues correctly? 1. Switch _GNU_SOURCE || _BSD_SOURCE -> just _GNU_SOURCE? FWIW, _BSD_SOURCE currently exposes the AT_STATX_* flags in fcntl.h. 2. uint64_t -> unsigned long long guarded by #ifdef __GNUC__ __extension__? Or just leave it as-is? 4. An ENOSYS fallback to fstatat()? glibc's fallback returns EINVAL for AT_* flags it doesn't understand and ignores all STATX_* flags: it sets stx_mask to STATX_BASIC_STATS, fills in stx_uid/stx_gid/etc. and sets stx_btime to zero. Does that sound reasonable?