mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: dalias@libc.org
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] getentropy: fail if buffer not completely filled
Date: Sun, 10 Apr 2022 00:50:07 +0200	[thread overview]
Message-ID: <CAHmME9o4C_G2CvmE-K8HVbZCbvdDUKp0XHJ0C28mmTs_zywGTw@mail.gmail.com> (raw)
In-Reply-To: <20220409131816.GJ7074@brightrain.aerifal.cx>

Hi Rich,

I can get rid of the <= case. glibc's paranoia might not actually make
sense. Actually, presumably one can just get rid of the entire loop,
assuming the < 256 guarantee continues to hold.

I'll send you two patches, one that moderately fixes up this v1
(called v2) and one that gets rid of the loop entirely (v3).

Jason

  reply	other threads:[~2022-04-10 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  0:10 Jason A. Donenfeld
2022-04-09 13:18 ` Rich Felker
2022-04-09 22:50   ` Jason A. Donenfeld [this message]
2022-04-09 22:58     ` [musl] [PATCH v2] " Jason A. Donenfeld
2022-04-09 22:58       ` [musl] [PATCH v3] " Jason A. Donenfeld
2022-04-10 15:30       ` [musl] [PATCH v2] " Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9o4C_G2CvmE-K8HVbZCbvdDUKp0XHJ0C28mmTs_zywGTw@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    --subject='Re: [musl] [PATCH] getentropy: fail if buffer not completely filled' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).