From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12558 Path: news.gmane.org!.POSTED!not-for-mail From: Andre McCurdy Newsgroups: gmane.linux.lib.musl.general Subject: Re: clz instruction is unavailable for Thumb1 Date: Tue, 27 Feb 2018 16:37:15 -0800 Message-ID: References: <1799b81c-10d6-c2ac-4411-6ee9808f2356@codeaurora.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1519778128 27654 195.159.176.226 (28 Feb 2018 00:35:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2018 00:35:28 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-12574-gllmg-musl=m.gmane.org@lists.openwall.com Wed Feb 28 01:35:24 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eqpiO-0006oY-CP for gllmg-musl@m.gmane.org; Wed, 28 Feb 2018 01:35:24 +0100 Original-Received: (qmail 13608 invoked by uid 550); 28 Feb 2018 00:37:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13588 invoked from network); 28 Feb 2018 00:37:27 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Ifc8cBndykkg7LB3z4R0QgPtqpp+AhSl9Sog4HyxeWs=; b=mlvIRBpwOU9puWXXSDJlhOxpM1BsYDpCnMnVJMI9W3HGX6ilPtNDaB01zR2Zil+Pom 4WdiMmHHs8NVCAhU3CRJ2f1+UaHnmz1qhpUyGrY3ujkhNR7nRqqxtILzyFNc+PUSke8a Eu/N2LHvUyJ94q9EZMZfI7u3mBaQxqkKssvimDi2kb3rwTZ2OhkNTL8n+zeqOSDzflOR XyLgxyhwxVA/1aSwCVKUN6HKd9nKao2to3xoUkySpJbwJCJETHgiYCyeqoLQKXfLm4r1 ZmIcL1ofVrqkWb9RXyFXVhHGrud69ubOKD7sh8k+SMT3Cz+KOWKMY744CAVQgIsd/Ojy iwng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Ifc8cBndykkg7LB3z4R0QgPtqpp+AhSl9Sog4HyxeWs=; b=f5CAOlNms1snC2rnODFRQdPA4Op1i7r1KH2tZcbL0dg+myWL3jDSrbGJBRclrAjE+a VLtu0K/nIpeBCREmHTGHv11bIYreBts6L7Fnz9oJxFjFYwUAFdmGtIFC7wMhvD1FXCHb hI7SXXKpn38qW82G2dxOu41glNN3HWdcbuzR5DolsMmsRsal3IB9VSwqHHYbWZQ6Ldqa mxwmE16Khi2tBRl45oRLcLYluFImEQbA7hu/ZIel/eXXYC4Ge00dYObJd8ZbJ8pqQv8B zZgT2Z2Z96YYoEE9ff89AJNLpIqxi9nwGjIyjLseIO9YlYN8oyaNVC+6rIqCC9aDKEmT U0pw== X-Gm-Message-State: APf1xPCPyQ50d6ufiGW74nZTL+/z45SH/QfqWwsIQ1kmLbkAwFQq3cJ/ xf4d8zMIRTmBmE80p8ZXOwqENllUYzba0WrC0N4= X-Google-Smtp-Source: AG47ELsZ4q+DZQVwPld8LeUyzU+472+g0DQlLO/oOQlsRMepCDZBJP2DeKH7+PUM0eHnX+LaKQmBlFtWZZEwQUGkT44= X-Received: by 10.28.190.18 with SMTP id o18mr13144985wmf.86.1519778235506; Tue, 27 Feb 2018 16:37:15 -0800 (PST) In-Reply-To: <1799b81c-10d6-c2ac-4411-6ee9808f2356@codeaurora.org> Xref: news.gmane.org gmane.linux.lib.musl.general:12558 Archived-At: On Tue, Feb 27, 2018 at 4:03 PM, Zhao, Weiming wrote: > In arch/arm/atomic_arch.h, it checks for __ARM_ARCH >= 5, which is not > sufficient. > > for example, for armv6-m, it only support Thumb1, which doesn't include clz. > > Suggest to check if it's building for thumb1: Musl does not currently support Thumb 1. > diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h > index c5c56f8..e3cb66a 100644 > --- a/arch/arm/atomic_arch.h > +++ b/arch/arm/atomic_arch.h > @@ -82,7 +82,7 @@ static inline void a_crash() > : : : "memory"); > } > > -#if __ARM_ARCH >= 5 > +#if __ARM_ARCH >= 5 && !(defined(__thumb__) && !defined(__thumb2)) > > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation >