From: Andre McCurdy <armccurdy@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH] arm: avoid conditional branch to PLT in sigsetjmp.s
Date: Thu, 21 Nov 2019 12:54:41 -0800 [thread overview]
Message-ID: <CAJ86T=V8Pu54XX1waFQT7+w_Z_2TTuNQk4e6jRcGLvQZi9Q7ww@mail.gmail.com> (raw)
In-Reply-To: <20190918195406.GB9017@brightrain.aerifal.cx>
On Wed, Sep 18, 2019 at 12:54 PM Rich Felker <dalias@libc.org> wrote:
> On Wed, Sep 18, 2019 at 10:52:13AM -0700, Andre McCurdy wrote:
> > On Wed, Sep 18, 2019 at 7:29 AM Khem Raj <raj.khem@gmail.com> wrote:
> > > On Tue, Sep 17, 2019 at 11:04 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> > > >
> > > > The R_ARM_THM_JUMP19 relocation type generated for the original code
> > > > when targeting Thumb 2 is not supported by the gold linker:
> > > >
> > > > | .../arm-oe-linux-musleabi/9.2.0/ld: error: conditional branch to PLT in THUMB-2 not supported yet.
> > > > | src/signal/arm/sigsetjmp.s:9: error: unexpected opcode while processing relocation R_ARM_THM_JUMP19
> > >
> > > if it is thumb2 specific another option could be to use `it eq` before
> > > beq which should turn branch into an unconditional branch, which then
> > > uses R_ARM_THM_JUMP24 relocation that has a range of 16MB.
> >
> > That would work too. Thumb 2 specific code would need to be guarded by
> > #ifdef __thumb2__ though (which I think implies also renaming the file
> > from .s to .S ?) and I'm not sure if the extra complexity justifies
> > saving one instruction in the ARM case.
>
> I don't think it does. Also, current style is not to use "it" at all,
> but rather -Wa,-mimplicit-it=always. I'm not sure if unified syntax
> accepts "it" in arm mode when the following insn has a matching
> condition suffix, but here it wouldn't I think...
Any issues with merging this now?
next prev parent reply other threads:[~2019-11-21 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 6:04 Andre McCurdy
2019-09-18 14:28 ` Khem Raj
2019-09-18 17:52 ` Andre McCurdy
2019-09-18 19:54 ` Rich Felker
2019-11-21 20:54 ` Andre McCurdy [this message]
2019-12-07 18:03 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ86T=V8Pu54XX1waFQT7+w_Z_2TTuNQk4e6jRcGLvQZi9Q7ww@mail.gmail.com' \
--to=armccurdy@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).