From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14282 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andre McCurdy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix build failure on arm because of missing clz instruction Date: Fri, 28 Jun 2019 15:55:56 -0700 Message-ID: References: <20180824193052.GD4418@port70.net> <20180824232027.GO1878@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225814"; mail-complaints-to="usenet@blaine.gmane.org" To: musl@lists.openwall.com Original-X-From: musl-return-14298-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jun 29 00:56:24 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hgzn6-000wgU-0e for gllmg-musl@m.gmane.org; Sat, 29 Jun 2019 00:56:24 +0200 Original-Received: (qmail 3132 invoked by uid 550); 28 Jun 2019 22:56:21 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 3114 invoked from network); 28 Jun 2019 22:56:20 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=fa8cv/JtyXkRJpxaoc+MCH+QTiu6IDyfy8iKYbixfE8=; b=UkC9Q4UkWBWHiEy7VgRGkcKBbuwi+Yxag5sPyllU1ptS8xb99rYABs6kMeslgA7/AD LhjN9IapUWdgeOHUm9LCr2wg4A0qxigUjTxJzdFouqbrVWAenOmXvesONFybVjBup6td JmGSwWjiJu/EsdG8dLqlA12FPH3QX8Ts18YXJCNaAJ761s91uELjcaCKLLe5U033Moku 8hdCcjTEwEeOEYm3q+6+mk3/JcbRREdFBPWT6mpdV5leVpTFgZD9u5gFBeMvSbweK64T d3n8IpcljrWUkcw6ew4sWNHVWqPzKUhHomwEYBHzqtHh+kYRZClMaVTe3d8cT2+G/DdE Aw9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=fa8cv/JtyXkRJpxaoc+MCH+QTiu6IDyfy8iKYbixfE8=; b=YsybzkegN0kqzAAajEiSIk3V7Jzqr44pBXPp3CvcnE8XjgLXoNNMFeQEervBscTjA2 5Wfea0V4Pijo5cyVX0kE3xTJcIbFxcuqoiLYLeW003nGF2Zu3PTKu2PLRH5rOFL3OdNC RZnSr4aqtoR+a192KnIsu2Q46IXlOutg+QqNgICpqHeqmelIczWDxY6/ngTeSVeKhq12 kkN4S7A6HqBZaBc2i6bcvcUzQUZ8MhVuImM+h+3iONMpfX31gR2BVHP3QFZYJgj1IyAR JKzwPG8i1Y1FrvQCJhBlMJmStKwUm9jpWQwEvIjLT6+7z+EgstsEWoAQSZX8k2Bm3vd9 5hpg== X-Gm-Message-State: APjAAAVrLQo8Jlp6xALOtaGPTECndzsCqIptcrIqA8U92ui23q5WTiq9 YbuD8yh4OF6vliB+DarXqhcnBn/0ozliad5HmkfWVIRq X-Google-Smtp-Source: APXvYqwEbAmdRyJujx9L/VEu/Z24DdzxbkWI2IZ+tW6PurE6fIlCxhkJ+3m6lPSjyO9k2/pKAOqHAnQ0IpxaiGbBJvI= X-Received: by 2002:a67:ed87:: with SMTP id d7mr28367vsp.130.1561762568454; Fri, 28 Jun 2019 15:56:08 -0700 (PDT) In-Reply-To: <20180824232027.GO1878@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14282 Archived-At: On Fri, Aug 24, 2018 at 4:20 PM Rich Felker wrote: > On Fri, Aug 24, 2018 at 02:58:04PM -0700, Andre McCurdy wrote: > > On Fri, Aug 24, 2018 at 12:30 PM, Szabolcs Nagy wrote: > > > another arm patch, clz usage (in fma) was broken with -mthumb -march=armv5t. > > > > That conditional was originally written under the assumption that musl > > doesn't support thumb1 (so -mthumb -march=armv5t is not a supported > > configuration). > > > > Was that assumption wrong? > > musl does not support being pure-thumb1 code, because some of the asm > source files are not thumb-compatible, but I think the C code can be > compiled as thumb1. -mthumb is only passed to the assembler for asm > source files if __thumb2__ is defined. Sorry to resurrect such an old thread, but it seems this patch was never applied? Without it, -mthumb -march=armv5t still fails to build due to clz getting into C code via inline assembler.