From: Andre McCurdy <armccurdy@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] arm: enable a_ll and a_sc helper functions when building for ARMv6T2
Date: Thu, 19 Apr 2018 12:14:51 -0700 [thread overview]
Message-ID: <CAJ86T=WAumSgGVukPxxGGr4CFd8a3B-WQcyBdkSL6CEN=x6BCg@mail.gmail.com> (raw)
In-Reply-To: <20180419163851.GL3094@brightrain.aerifal.cx>
On Thu, Apr 19, 2018 at 9:38 AM, Rich Felker <dalias@libc.org> wrote:
> On Wed, Apr 18, 2018 at 06:51:44PM -0700, Andre McCurdy wrote:
>> ARMv6 cores with support for Thumb2 can take advantage of the "ldrex"
>> and "strex" based implementations of a_ll and a_sc.
>> ---
>> arch/arm/atomic_arch.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h
>> index 5ff1be1..62458b4 100644
>> --- a/arch/arm/atomic_arch.h
>> +++ b/arch/arm/atomic_arch.h
>> @@ -8,7 +8,7 @@ extern uintptr_t __attribute__((__visibility__("hidden")))
>> __a_cas_ptr, __a_barrier_ptr;
>>
>> #if ((__ARM_ARCH_6__ || __ARM_ARCH_6K__ || __ARM_ARCH_6KZ__ || __ARM_ARCH_6ZK__) && !__thumb__) \
>> - || __ARM_ARCH_7A__ || __ARM_ARCH_7R__ || __ARM_ARCH >= 7
>> + || __ARM_ARCH_6T2__ || __ARM_ARCH_7A__ || __ARM_ARCH_7R__ || __ARM_ARCH >= 7
>>
>> #define a_ll a_ll
>> static inline int a_ll(volatile int *p)
>
> I'm merging this along with the others, but there is some concern that
> our use of a_ll/a_sc might not actually be valid on most or all of the
> archs we currently use it on. Depending on how this turns out it might
> all be removed at some later time.
That sound ominous. What's the concern?
next prev parent reply other threads:[~2018-04-19 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 1:51 [PATCH 0/2] Improved feature testing for ARMv6 Andre McCurdy
2018-04-19 1:51 ` [PATCH 1/2] arm: respect both __ARM_ARCH_6KZ__ and __ARM_ARCH_6ZK__ macros Andre McCurdy
2018-04-19 1:51 ` [PATCH 2/2] arm: enable a_ll and a_sc helper functions when building for ARMv6T2 Andre McCurdy
2018-04-19 16:38 ` Rich Felker
2018-04-19 19:14 ` Andre McCurdy [this message]
2018-04-19 19:25 ` Rich Felker
2018-04-19 20:38 ` Andre McCurdy
2018-04-19 21:32 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ86T=WAumSgGVukPxxGGr4CFd8a3B-WQcyBdkSL6CEN=x6BCg@mail.gmail.com' \
--to=armccurdy@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).