From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12747 Path: news.gmane.org!.POSTED!not-for-mail From: Andre McCurdy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] arm: enable a_ll and a_sc helper functions when building for ARMv6T2 Date: Thu, 19 Apr 2018 12:14:51 -0700 Message-ID: References: <1524102704-8973-1-git-send-email-armccurdy@gmail.com> <1524102704-8973-3-git-send-email-armccurdy@gmail.com> <20180419163851.GL3094@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1524165180 1500 195.159.176.226 (19 Apr 2018 19:13:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 19 Apr 2018 19:13:00 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-12763-gllmg-musl=m.gmane.org@lists.openwall.com Thu Apr 19 21:12:56 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1f9EzH-0000JG-Oo for gllmg-musl@m.gmane.org; Thu, 19 Apr 2018 21:12:55 +0200 Original-Received: (qmail 19893 invoked by uid 550); 19 Apr 2018 19:15:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 19873 invoked from network); 19 Apr 2018 19:15:03 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=m9jWxXyX375rdz7z24NC0LtFTB0kTo4qyLNQLigx5vU=; b=S/ccMc2mTE7tyYAhByT4juwnuemyW9uDgJD8BYpyJIjZxKSb73PjFzW8C4Kv5Lmj5x 2yI/Cstqzw6hbpcNFL5TlcACubAAS3S4icfYDqqxtuYawjrhh+REE73rulqyG1xSsIVt gDxUPgyKWW3vj5irVxvX85Z2p/UW4IlbiVu87WAszgti8tlZ/p2BqkSD7nYApIzKf3AV 0hWoZr+cxp3fs4CUAh5nJNQ92lQ0N2QJPxNag18JszI2WVOYZ83gzmtagK459oMMPvSq HV2DrWiw1y0iJMt2FO6jU1HjTi13eitrXIV/eDMP3fXIHQArvQ+IHNQvyCu34i0Rta7G l/qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=m9jWxXyX375rdz7z24NC0LtFTB0kTo4qyLNQLigx5vU=; b=LYaDwKPLbdSfHChvs1tBTMr3D5wVChA7dw69PKAa9zQ7QsTBDAVYZsye3uQKLDCsQ+ 3h1em0CjYyg78LzgyxZtmjrfV7Mlc+Q82ZbHqvWMDj2nqKK2CDc3O/qFX4ZMQB1QIyjA FlLPGjXb9Rl7q99CdLRLwadNBg6MvmASV2iaMs+ukP7Q4Lvms+yTnxQ4dyrqHhvwIZyd OR3sXBhKT46fIdkFrPxVdBOkRcmiN1BG/o34KgadWpEMSgyfwt4CG+oqX/S8qY6kePQo mSYPzASmf4PlmRaXqi7fWEDEdoBnJR1tiGM4DTBDKE+Bv7mjRgu8/6LFTqO6tZ24SFWL ka0A== X-Gm-Message-State: ALQs6tCknawN/zf/9dLy1e3IG+nZijPUlxCszIxmmKy14vukpXjHMQZJ ulB6/RtQQPPr0LnqgaQTHZlqWy4fdpzwkTlawtw= X-Google-Smtp-Source: AB8JxZrK2f9wewSxtFfYbz25StDC0yCR3Y1HmkcbDDYDzNdmw+WA4QC1rahMhbcfvVXHuJ3CP8/gAzWa72RS6RvnBIA= X-Received: by 10.28.63.148 with SMTP id m142mr1761wma.153.1524165291918; Thu, 19 Apr 2018 12:14:51 -0700 (PDT) In-Reply-To: <20180419163851.GL3094@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:12747 Archived-At: On Thu, Apr 19, 2018 at 9:38 AM, Rich Felker wrote: > On Wed, Apr 18, 2018 at 06:51:44PM -0700, Andre McCurdy wrote: >> ARMv6 cores with support for Thumb2 can take advantage of the "ldrex" >> and "strex" based implementations of a_ll and a_sc. >> --- >> arch/arm/atomic_arch.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h >> index 5ff1be1..62458b4 100644 >> --- a/arch/arm/atomic_arch.h >> +++ b/arch/arm/atomic_arch.h >> @@ -8,7 +8,7 @@ extern uintptr_t __attribute__((__visibility__("hidden"))) >> __a_cas_ptr, __a_barrier_ptr; >> >> #if ((__ARM_ARCH_6__ || __ARM_ARCH_6K__ || __ARM_ARCH_6KZ__ || __ARM_ARCH_6ZK__) && !__thumb__) \ >> - || __ARM_ARCH_7A__ || __ARM_ARCH_7R__ || __ARM_ARCH >= 7 >> + || __ARM_ARCH_6T2__ || __ARM_ARCH_7A__ || __ARM_ARCH_7R__ || __ARM_ARCH >= 7 >> >> #define a_ll a_ll >> static inline int a_ll(volatile int *p) > > I'm merging this along with the others, but there is some concern that > our use of a_ll/a_sc might not actually be valid on most or all of the > archs we currently use it on. Depending on how this turns out it might > all be removed at some later time. That sound ominous. What's the concern?