mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Jacob Abrams <jacob@clover.com>
To: musl@lists.openwall.com
Subject: vprintf.c bug
Date: Tue, 26 Jul 2016 15:25:40 -0700	[thread overview]
Message-ID: <CAJJ2OC3eGmk6pN0bEbhvRcHDTauEbB2VNj6qpK41uGj88YKNFQ@mail.gmail.com> (raw)

I believe there is a small bug in vfprintf.c

I had to change the if statement from

    ret = printf_core(f, fmt, &ap2, nl_arg, nl_type);
    if (saved_buf) {

to

    ret = printf_core(f, fmt, &ap2, nl_arg, nl_type);
    if (f->buf == internal_buf) {

Because the saved_buf may be NULL which will result the internal
buffer being used but the file not being reset properly after the call
to printf_core. This was discovered while using MUSL v1.1.4 on an OS
other than Linux.

Please cc-me on any response.

Regards,
Jacob
jacob@clover.com


             reply	other threads:[~2016-07-26 22:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 22:25 Jacob Abrams [this message]
2016-07-27  3:17 ` Rich Felker
2016-08-02 20:02   ` Jacob Abrams
2016-08-02 20:11     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJJ2OC3eGmk6pN0bEbhvRcHDTauEbB2VNj6qpK41uGj88YKNFQ@mail.gmail.com \
    --to=jacob@clover.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).