From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 3A1BA2421B for ; Thu, 1 Feb 2024 17:20:42 +0100 (CET) Received: (qmail 28154 invoked by uid 550); 1 Feb 2024 16:18:11 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 4052 invoked from network); 1 Feb 2024 15:51:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706802820; x=1707407620; darn=lists.openwall.com; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cI8m76gemHXeUCSJx1GB+uk/1elk4BxYfrw1QVJRIZM=; b=Ngyb/0HSPn/iwXKlPA8026RP3mzdEgWvlv8IZjSlgogCTEuQ2L95/MBmoDG5Dx114y jgoxvS8axDdL3px0k1HDIS7k0/TBEmGQLh+6GwUpuwmpFffH6dhyAEAzXweVXr3IYNU/ SaSmAxIc7h0Wn0tEtSo7IhaDrBWO+5eg5NsI7Ck/cOpNaRU+41GwfaB18vt7LGY39JHp Owvj4CtnxZR/NcB5HEScy/G+fGMccM/GUT0Wbu3QmTqnlOmEwv9ASpcO6VSfTyUY3XRB Dh9+kAFBLnJ2lJBCMnBwJkgSHfbkjweht4EuBo6rT7ZaaiISnuxtsf4hioJHmmBsj2au gjUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706802820; x=1707407620; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cI8m76gemHXeUCSJx1GB+uk/1elk4BxYfrw1QVJRIZM=; b=EqM7uvkq5J/shAcYB6Ai2RRp+32yTYw4ee5jxaJ109wsY3ZsJhqbsmJ5YrpbGRi+Z+ Q/+7lgQhixI9TXY+ft73FtkGOgVayg933z0R6IouO1MhA2qul+UvqqTKkbc9Te2E03U9 nFDo7uyNLVLBg214PMW4E8RKzl1HzJOsTO5mylN09oM+m/K5IxHGPNVZVaN4sJ2EjUI7 G6BZ89eyvEZ1APX8Hzj0XVOXe0oslWzG+/q+mof7KujWFwOp8OH3RuZ40K/1pxTMa6ZK dOLRxeZiauu8LbEsWkGfvimUhUYFaVuiZokCACpUOq5XjTUkvGkoLOOL5vo1lU8BdpkB Qjvg== X-Gm-Message-State: AOJu0YwrtEu7DMoQj/R+In0E+C9GPGx0ak5bHfiwxBHJL4QW+YlCErS1 zZibH5LGceVYPGADbzytwkrlMuOp21CK4DcHSwY57SdwAEH/GiEjWlXuZavT7piTmaaQTFqESNz RACqAy2KBQsNaa/+k/EbeE0AjvJd5tUYmdQ== X-Google-Smtp-Source: AGHT+IHir7zegXmfaQd4kHYGIkOTZetFZVWumWa4o+m6OCqQnVEim42e0w2MdsDxzutkTt9hDBe6BcFRXUMNDvafhv4= X-Received: by 2002:a17:907:d388:b0:a36:c190:1242 with SMTP id vh8-20020a170907d38800b00a36c1901242mr2133312ejc.12.1706802819961; Thu, 01 Feb 2024 07:53:39 -0800 (PST) MIME-Version: 1.0 References: <20240201142719.GV4163@brightrain.aerifal.cx> In-Reply-To: <20240201142719.GV4163@brightrain.aerifal.cx> From: Andrew Cagney Date: Thu, 1 Feb 2024 10:53:27 -0500 Message-ID: To: Rich Felker Cc: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [musl] glob(GLOB_BRACE) On Thu, 1 Feb 2024 at 09:27, Rich Felker wrote: > > On Thu, Feb 01, 2024 at 08:48:01AM -0500, Andrew Cagney wrote: > > FYI, It's on the BSDs and glibc. > > Found by libreswan's test framework on alpine. > For glob and GLOB_BRACE, it looks like it's "just" a matter of > iterating over the different expansions and applying glob to each, but > it seems to be underspecified how it interacts with escaping, special > chars, slashes, etc. > > Do you have good reasons in favor of inclusion? My impression is that > everything that wants/needs it is shipping its own version of GNU glob > or whatever that has it, or else very little is using it; otherwise it > would have come up before. But if adding it allowed a lot of things to > drop GNU glob and just use the libc glob, that might be compelling. for libreswan, after some digging: 2007 new code added with glob(GLOB_BRACE) call 2014 #ifdef GLOB_BRACE added; it turns out due to musl 2024 while merging some glob() calls; problem re-discovered So libreswan took the path of least resistance. I suspect it wasn't alone. Including it would let libreswan's config files be consistent across platforms - no need for special documentation. However, I also wonder if libreswan needs GLOB_BRACE. It isn't needed to expand the recommended <>. I'll take that up with libreswan.