From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12104 Path: news.gmane.org!.POSTED!not-for-mail From: Miklos Szeredi Newsgroups: gmane.linux.kernel.api,gmane.linux.kernel,gmane.linux.file-systems,gmane.linux.lib.musl.general Subject: Re: [musl] Re: [(resend)] seq_file: reset iterator to first record for zero offset Date: Wed, 15 Nov 2017 11:34:58 +0100 Message-ID: References: <20161219113800.GE27207@veci.piliscsaba.szeredi.hu> <20171108131005.GA15263@port70.net> <20171110011419.GP1627@brightrain.aerifal.cx> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a1141e49433022b055e030e66" X-Trace: blaine.gmane.org 1510742105 31866 195.159.176.226 (15 Nov 2017 10:35:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Nov 2017 10:35:05 +0000 (UTC) Cc: Szabolcs Nagy , Al Viro , Tomasz Majchrzak , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux API , musl-ZwoEplunGu1jrUoiu81ncdBPR1lH4CV8@public.gmane.org To: Rich Felker Original-X-From: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Wed Nov 15 11:34:58 2017 Return-path: Envelope-to: glka-linux-api@m.gmane.org Original-Received: from vger.kernel.org ([209.132.180.67]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEv21-0006m5-6o for glka-linux-api@m.gmane.org; Wed, 15 Nov 2017 11:34:57 +0100 Original-Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand id S1757593AbdKOKfD (ORCPT ); Wed, 15 Nov 2017 05:35:03 -0500 Original-Received: from mail-wm0-f43.google.com ([74.125.82.43]:41648 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757587AbdKOKfA (ORCPT ); Wed, 15 Nov 2017 05:35:00 -0500 Original-Received: by mail-wm0-f43.google.com with SMTP id b189so1979045wmd.0 for ; Wed, 15 Nov 2017 02:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RtKpcuoo9AZWBRJyS7t6mFFNsX0Vq/ctOL60+IF4kkE=; b=GXLb6h3wIU0Xt4rO9Y9GRzSDOzKHvp/mLRFRLZ2SEMAzrK7kL3LqEyFiVw5BQgeqTb RooomrrSThQruwLwyVkMgp1ewF9IWhzW/rDwJMY6d2IAChrOj/8GrEvpHjsz/Zm7XOcP NNXxhQcFz8NK6isHeuxy/bonEU90Y/mS118+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RtKpcuoo9AZWBRJyS7t6mFFNsX0Vq/ctOL60+IF4kkE=; b=WZk0enWNbls/9K1KYXspkNnrvNSzaiNVDdAEn6Z2I7jA1T4DN7TzFhsNewMV7SwXb2 BX3hLUmkJQsQZmOReMgaPH38TJoemszdmDHv0oSzRIeDNCRrIzeVLUctBh4YVHlESEtS mffcJ0RN3E3zMzKn6s7gTAgmEAUO025nUxbugKyMFsaSzcKBseQgqmTEcBDEEdK9NEbK ihLAm6N1Q/m+cf6oc/ShUePmZwlkRDoIXxGR6U22iCDvWS79YfuIUFIE67hKDD3Nl0Jb vhB8QG531jaMsUrOtaLNbxDcuGn9JEnVYlHeyys9sfZQ/Yyye++FSaGlwa5zUSR8CQOK Q2tg== X-Gm-Message-State: AJaThX68B/lD4wTHaLHpFIXfgjTJt8Pq6gr4iGPt7P4yua0HazD91rNk HRxqmx6MVk0RaWGuL6kQuyuJ+D6yOWC85U7DksX0+A== X-Google-Smtp-Source: AGs4zMZ6ZT4uXQaw5KOvfIZ/unqC6cX1zSv9M0ShyS9gcQDYUPYilsqJvQNXuDqFOal50+B6YKruXbzh8gcGmqMI54U= X-Received: by 10.28.127.22 with SMTP id a22mr9093779wmd.12.1510742099673; Wed, 15 Nov 2017 02:34:59 -0800 (PST) Original-Received: by 10.223.161.208 with HTTP; Wed, 15 Nov 2017 02:34:58 -0800 (PST) X-Originating-IP: [194.176.227.33] In-Reply-To: <20171110011419.GP1627-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org> Original-Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Precedence: bulk List-ID: X-Mailing-List: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Xref: news.gmane.org gmane.linux.kernel.api:25710 gmane.linux.kernel:2617365 gmane.linux.file-systems:129055 gmane.linux.lib.musl.general:12104 Archived-At: --001a1141e49433022b055e030e66 Content-Type: text/plain; charset="UTF-8" On Fri, Nov 10, 2017 at 2:14 AM, Rich Felker wrote: > On Wed, Nov 08, 2017 at 02:10:05PM +0100, Szabolcs Nagy wrote: >> >> this patch broke userspace abi: >> >> commit e522751d605d99a81508e58390a8f51ee96fb662 > > Thanks for reporting this! Thanks for the report and the reproducer. Tested fix attached. Thanks, Miklos --001a1141e49433022b055e030e66 Content-Type: text/x-patch; charset="US-ASCII"; name="seq_file-fix-incomplete-reset-on-read-from-zero-offset.patch" Content-Disposition: attachment; filename="seq_file-fix-incomplete-reset-on-read-from-zero-offset.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ja0wtgqe0 RnJvbTogTWlrbG9zIFN6ZXJlZGkgPG1zemVyZWRpQHJlZGhhdC5jb20+ClN1YmplY3Q6IHNlcV9m aWxlOiBmaXggaW5jb21wbGV0ZSByZXNldCBvbiByZWFkIGZyb20gemVybyBvZmZzZXQKCldoZW4g cmVzZXR0aW5nIGl0ZXJhdG9yIG9uIGEgemVybyBvZmZzZXQgd2UgbmVlZCB0byBkaXNjYXJkIGFu eSBkYXRhCmFscmVhZHkgaW4gdGhlIGJ1ZmZlciAoY291bnQpLCBhbmQgcHJpdmF0ZSBzdGF0ZSBv ZiB0aGUgaXRlcmF0b3IgKHZlcnNpb24pLgoKRm9yIGV4YW1wbGUgdGhpcyBidWcgcmVzdWx0cyBp biBmaXJzdCBsaW5lIGJlaW5nIHJlcGVhdGVkIGluIC9wcm9jL21vdW50cwppZiBkb2luZyBhIHpl cm8gc2l6ZSByZWFkIGJlZm9yZSBhIG5vbi16ZXJvIHNpemUgcmVhZC4KClJlcG9ydGVkLWJ5OiBS aWNoIEZlbGtlciA8ZGFsaWFzQGxpYmMub3JnPiAKU2lnbmVkLW9mZi1ieTogTWlrbG9zIFN6ZXJl ZGkgPG1zemVyZWRpQHJlZGhhdC5jb20+CkZpeGVzOiBlNTIyNzUxZDYwNWQgKCJzZXFfZmlsZTog cmVzZXQgaXRlcmF0b3IgdG8gZmlyc3QgcmVjb3JkIGZvciB6ZXJvIG9mZnNldCIpCkNjOiA8c3Rh YmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMAotLS0KIGZzL3NlcV9maWxlLmMgfCAgICA1ICsr KystCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgotLS0g YS9mcy9zZXFfZmlsZS5jCisrKyBiL2ZzL3NlcV9maWxlLmMKQEAgLTE4MSw4ICsxODEsMTEgQEAg c3NpemVfdCBzZXFfcmVhZChzdHJ1Y3QgZmlsZSAqZmlsZSwgY2hhcgogCSAqIGlmIHJlcXVlc3Qg aXMgdG8gcmVhZCBmcm9tIHplcm8gb2Zmc2V0LCByZXNldCBpdGVyYXRvciB0byBmaXJzdAogCSAq IHJlY29yZCBhcyBpdCBtaWdodCBoYXZlIGJlZW4gYWxyZWFkeSBhZHZhbmNlZCBieSBwcmV2aW91 cyByZXF1ZXN0cwogCSAqLwotCWlmICgqcHBvcyA9PSAwKQorCWlmICgqcHBvcyA9PSAwKSB7CiAJ CW0tPmluZGV4ID0gMDsKKwkJbS0+dmVyc2lvbiA9IDA7CisJCW0tPmNvdW50ID0gMDsKKwl9CiAK IAkvKiBEb24ndCBhc3N1bWUgKnBwb3MgaXMgd2hlcmUgd2UgbGVmdCBpdCAqLwogCWlmICh1bmxp a2VseSgqcHBvcyAhPSBtLT5yZWFkX3BvcykpIHsK --001a1141e49433022b055e030e66--