From: enh <email@example.com>
To: Khem Raj <firstname.lastname@example.org>
Subject: Re: [musl] SA_RESTORER for rv64?
Date: Fri, 3 Feb 2023 10:44:56 -0800 [thread overview]
Message-ID: <CAJgzZoq7LNyhmjU+zHxnZjCcikaD_WPJpSn8V=U+oqwMeE+YGw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
oops, never actually sent the patch. attached...
On Thu, Nov 10, 2022 at 9:31 AM Khem Raj <email@example.com> wrote:
> On Thu, Nov 10, 2022 at 9:19 AM Rich Felker <firstname.lastname@example.org> wrote:
> > On Thu, Nov 10, 2022 at 07:44:23AM -0800, enh wrote:
> > > arch/riscv64/bits/signal.h has contained a definition for SA_RESTORER since
> > > the initial commit, but i think that's just copy & paste from whichever
> > > architecture the rv64 headers were based on? the linux kernel itself
> > > doesn't have SA_RESTORER for rv64, unless i'm missing something?
> > I suspect this is just a mistake. Have you seen any ill effects from
> > it? If riscv folks can confirm it's wrong, I'll remove it.
> Yeah I think it should be removed. Perhaps mips is in same boat.
> > Rich
[-- Attachment #2: 0001-risc-v-does-not-have-SA_RESTORER.patch --]
[-- Type: text/x-patch, Size: 795 bytes --]
From 6413de6d9f785c98e5bc0cf40be947f1169d2fd7 Mon Sep 17 00:00:00 2001
From: Elliott Hughes <email@example.com>
Date: Fri, 3 Feb 2023 10:42:55 -0800
Subject: [PATCH] risc-v does not have SA_RESTORER.
The kernel's include/uapi/asm-generic/signal-defs.h explicitly calls
this out as obsolete. New architectures like risc-v do not define it.
arch/riscv64/bits/signal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv64/bits/signal.h b/arch/riscv64/bits/signal.h
index 287367db..fd6157a3 100644
@@ -76,7 +76,6 @@ typedef struct __ucontext
#define SA_RESTART 0x10000000
#define SA_NODEFER 0x40000000
#define SA_RESETHAND 0x80000000
-#define SA_RESTORER 0x04000000
next prev parent reply other threads:[~2023-02-03 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:44 enh
2022-11-10 17:18 ` Rich Felker
2022-11-10 17:26 ` enh
2022-11-10 17:31 ` Khem Raj
2023-02-03 18:44 ` enh [this message]
2023-02-05 23:54 ` Rich Felker
2023-02-06 16:51 ` enh
2023-02-06 17:49 ` Rich Felker
2023-02-08 21:45 ` Rich Felker
2023-02-08 21:53 ` enh
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).