[musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Fangrui Song]

see

  https://groups.google.com/g/generic-abi/c/satyPkuMisk
  Add new ch_type value: ELFCOMPRESS_ZSTD
---
 include/elf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/elf.h b/include/elf.h
index 86e2f0bb..d2231ba0 100644
--- a/include/elf.h
+++ b/include/elf.h
@@ -436,6 +436,7 @@ typedef struct {
 } Elf64_Chdr;
 
 #define ELFCOMPRESS_ZLIB	1
+#define ELFCOMPRESS_ZSTD	2
 #define ELFCOMPRESS_LOOS	0x60000000
 #define ELFCOMPRESS_HIOS	0x6fffffff
 #define ELFCOMPRESS_LOPROC	0x70000000
-- 
2.37.1

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Rich Felker]

On Mon, Jul 25, 2022 at 07:14:33PM -0700, Fangrui Song wrote:
> see
> 
>   https://groups.google.com/g/generic-abi/c/satyPkuMisk
>   Add new ch_type value: ELFCOMPRESS_ZSTD
> ---
>  include/elf.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/elf.h b/include/elf.h
> index 86e2f0bb..d2231ba0 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -436,6 +436,7 @@ typedef struct {
>  } Elf64_Chdr;
>  
>  #define ELFCOMPRESS_ZLIB	1
> +#define ELFCOMPRESS_ZSTD	2
>  #define ELFCOMPRESS_LOOS	0x60000000
>  #define ELFCOMPRESS_HIOS	0x6fffffff
>  #define ELFCOMPRESS_LOPROC	0x70000000
> -- 
> 2.37.1

Is this actually an adopted standard? It's not clear from the link
above whether there's anything authoritative going on or a proposal
that some people like.

Rich

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Fangrui Song]

On 2022-08-02, Rich Felker wrote:
>On Mon, Jul 25, 2022 at 07:14:33PM -0700, Fangrui Song wrote:
>> see
>>
>>   https://groups.google.com/g/generic-abi/c/satyPkuMisk
>>   Add new ch_type value: ELFCOMPRESS_ZSTD
>> ---
>>  include/elf.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/elf.h b/include/elf.h
>> index 86e2f0bb..d2231ba0 100644
>> --- a/include/elf.h
>> +++ b/include/elf.h
>> @@ -436,6 +436,7 @@ typedef struct {
>>  } Elf64_Chdr;
>>
>>  #define ELFCOMPRESS_ZLIB	1
>> +#define ELFCOMPRESS_ZSTD	2
>>  #define ELFCOMPRESS_LOOS	0x60000000
>>  #define ELFCOMPRESS_HIOS	0x6fffffff
>>  #define ELFCOMPRESS_LOPROC	0x70000000
>> --
>> 2.37.1
>
>Is this actually an adopted standard? It's not clear from the link
>above whether there's anything authoritative going on or a proposal
>that some people like.
>
>Rich

I think so, from Cary's https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ
"I will add this to the ELF spec, as proposed below:".

This question isn't alone. Carlos O'Donell asked on https://sourceware.org/pipermail/libc-alpha/2022-July/141130.html
"Is there a public repo that I can use to cross-check the glibc value with the accepted ELF gABI value?"


Let me summarize the history:

Roughly since 2015 https://groups.google.com/g/generic-abi/c/IakWYdGABjQ/m/7zTiAVveBAAJ
("Heads Up: John Wolfe no longer at Xinuos Inc"), the official generic ABI website
http://www.sco.com/developers/gabi/latest/contents.html no longer gets update. (I believe the last
change was https://groups.google.com/g/generic-abi/c/dBOS1H47Q64/m/jwc9xA9o0IsJ
"Proposed gABI addition: SHF_COMPRESS").

Since https://groups.google.com/g/generic-abi/c/9OO5vhxb00Y/m/Y0WthoOcCQAJ ("Ongoing Maintenance of the gABI"), 
Cary Coutant takes on the maintenance of the gABI spec.

At the moment there is no repository. If help is needed, I am happy to convert the
/developers/gabi/latest .html files to Markdown or reST.

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Cary Coutant]

> >Is this actually an adopted standard? It's not clear from the link
> >above whether there's anything authoritative going on or a proposal
> >that some people like.
> >
> >Rich
>
> I think so, from Cary's https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ
> "I will add this to the ELF spec, as proposed below:".
>
> This question isn't alone. Carlos O'Donell asked on https://sourceware.org/pipermail/libc-alpha/2022-July/141130.html
> "Is there a public repo that I can use to cross-check the glibc value with the accepted ELF gABI value?"

Yes, this is officially approved. The gABI committee runs mostly on
consensus, but as a representative for Xinuos, I can offer the formal
stamp of approval.

I am under contract with Xinuos to maintain the ELF standard, and I
have converted it from raw HTML to ReStructuredText format, with the
goal of placing it into a github repository. That last part is not yet
done, but as soon as I can, I'll make an updated version of the spec
available. Until then, you'll need to reference the June 2013 version,
with various gABI discussions to serve as amendments. As another
quasi-authoritative source, the ELF include files in the binutils git
repository are kept up to date with the gABI changes, and I'm about to
commit a change there to reflect the new compression type.

-cary

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Szabolcs Nagy]

* Fangrui Song <i@maskray.me> [2022-08-02 13:01:26 -0700]:
> On 2022-08-02, Rich Felker wrote:
> > 
> > Is this actually an adopted standard? It's not clear from the link
> > above whether there's anything authoritative going on or a proposal
> > that some people like.
> 
> I think so, from Cary's https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ
> "I will add this to the ELF spec, as proposed below:".

i think at this point the closest to a single point of truth for
the elf spec is cary's approval mails on the generic abi list.

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Fangrui Song]

On Wed, Aug 3, 2022 at 3:00 AM Szabolcs Nagy <nsz@port70.net> wrote:
>
> * Fangrui Song <i@maskray.me> [2022-08-02 13:01:26 -0700]:
> > On 2022-08-02, Rich Felker wrote:
> > >
> > > Is this actually an adopted standard? It's not clear from the link
> > > above whether there's anything authoritative going on or a proposal
> > > that some people like.
> >
> > I think so, from Cary's https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ
> > "I will add this to the ELF spec, as proposed below:".
>
> i think at this point the closest to a single point of truth for
> the elf spec is cary's approval mails on the generic abi list.

Can this be picked? glibc and FreeBSD have defined this for a few months now...

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Fangrui Song]

On Mon, Nov 7, 2022 at 11:21 PM Fangrui Song <i@maskray.me> wrote:
>
> On Wed, Aug 3, 2022 at 3:00 AM Szabolcs Nagy <nsz@port70.net> wrote:
> >
> > * Fangrui Song <i@maskray.me> [2022-08-02 13:01:26 -0700]:
> > > On 2022-08-02, Rich Felker wrote:
> > > >
> > > > Is this actually an adopted standard? It's not clear from the link
> > > > above whether there's anything authoritative going on or a proposal
> > > > that some people like.
> > >
> > > I think so, from Cary's https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ
> > > "I will add this to the ELF spec, as proposed below:".
> >
> > i think at this point the closest to a single point of truth for
> > the elf spec is cary's approval mails on the generic abi list.
>
> Can this be picked? glibc and FreeBSD have defined this for a few months now...

Ping:)   Hope that https://www.openwall.com/lists/musl/2022/07/26/1
can land in the 1.2.4 release.

Re: [musl] [PATCH] elf.h: add ELFCOMPRESS_ZSTD

[Rich Felker]

On Sat, Feb 04, 2023 at 02:02:34PM -0800, Fangrui Song wrote:
> On Mon, Nov 7, 2022 at 11:21 PM Fangrui Song <i@maskray.me> wrote:
> >
> > On Wed, Aug 3, 2022 at 3:00 AM Szabolcs Nagy <nsz@port70.net> wrote:
> > >
> > > * Fangrui Song <i@maskray.me> [2022-08-02 13:01:26 -0700]:
> > > > On 2022-08-02, Rich Felker wrote:
> > > > >
> > > > > Is this actually an adopted standard? It's not clear from the link
> > > > > above whether there's anything authoritative going on or a proposal
> > > > > that some people like.
> > > >
> > > > I think so, from Cary's https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ
> > > > "I will add this to the ELF spec, as proposed below:".
> > >
> > > i think at this point the closest to a single point of truth for
> > > the elf spec is cary's approval mails on the generic abi list.
> >
> > Can this be picked? glibc and FreeBSD have defined this for a few months now...
> 
> Ping:)   Hope that https://www.openwall.com/lists/musl/2022/07/26/1
> can land in the 1.2.4 release.

It's in my branch I left unpushed while I was away and not readily
available to address any problems that might have come up from those
commits. I'm back now and I'll take a quick look thru them and push
unless there's something incredibly stupid in need of fixing. Either
way this one will be included though. :-)

Rich