mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Denys Vlasenko <vda.linux@googlemail.com>
To: musl <musl@lists.openwall.com>, Rich Felker <dalias@libc.org>
Subject: Having hard time adding to CFLAGS
Date: Fri, 23 Oct 2015 00:31:09 +0200	[thread overview]
Message-ID: <CAK1hOcM2Tcdx3RRyYu8X55Ek9CrDZi7YENQs_3xj1mLb6-k2pA@mail.gmail.com> (raw)

Let's say I need to add a gcc option to my musl build.

configure says:
...
Some influential environment variables:
  CC                      C compiler command [detected]
  CFLAGS                  C compiler flags [-Os -pipe ...]
  CROSS_COMPILE           prefix for cross compiler and tools [none]
  LIBCC                   compiler runtime library [detected

So I try this, combining all possible ways of passing CFLAGS
(past experience is that different projects do it differently).

CFLAGS is in environment, and on both configure and make
command lines:

export CFLAGS="-falign-functions=1"    # for example
./configure CFLAGS="$CFLAGS"
make CFLAGS="$CFLAGS"

It does work, but resulting libc.so is twice as big:
   text       data        bss        dec        hex    filename
 564099       1944      11768     577811      8d113    musl.1/lib/libc.so
 917805       2130      11736     931671      e3757    musl.2/lib/libc.so

The cause is that gcc invocation for each .c file in both cases start normally:

gcc -std=c99 -nostdinc -ffreestanding -fexcess-precision=standard
-frounding-math -D_XOPEN_SOURCE=700 -I./arch/x86_64 -I./src/internal
-I./include...

but then, build without explicit CFLAGS use this:

... -Os -pipe -fomit-frame-pointer -fno-unwind-tables
-fno-asynchronous-unwind-tables -Wa,--noexecstack
-Werror=implicit-function-declaration -Werror=implicit-int
-Werror=pointer-sign -Werror=pointer-arith -include vis.h  -fPIC
-DSHARED -c -o src/aio/aio.lo src/aio/aio.c

and one with CFLAGS loses these flags, in particular, it has no -Os
and no -fPIC:

... -falign-functions=1 -c -o src/aio/aio.o src/aio/aio.c

Evidently, my CFLAGS replaced needed flags instead of being added at the end.

Can this be fixed? If user needs to use e.g. EXTRA_CFLAGS instead,
please fix configure --help.


             reply	other threads:[~2015-10-22 22:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 22:31 Denys Vlasenko [this message]
2015-10-22 23:04 ` Josiah Worcester
2015-10-23  0:13   ` Denys Vlasenko
2015-10-22 23:23 ` Szabolcs Nagy
2015-10-23  3:02   ` Rich Felker
2015-10-23  4:09     ` Rich Felker
2015-10-23  4:53       ` Denys Vlasenko
2015-10-23  5:16         ` Rich Felker
2015-10-23  6:47           ` Denys Vlasenko
2015-10-24 19:37             ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK1hOcM2Tcdx3RRyYu8X55Ek9CrDZi7YENQs_3xj1mLb6-k2pA@mail.gmail.com \
    --to=vda.linux@googlemail.com \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).