From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7093
Path: news.gmane.org!not-for-mail
From: Denys Vlasenko <vda.linux@googlemail.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Draft of improved memset.s for i386
Date: Tue, 24 Feb 2015 04:02:09 +0100
Message-ID: <CAK1hOcN0EaHwzH+LdnNntM1=3-rnHY-hotY1RBD0xB0qeb1SxQ@mail.gmail.com>
References: <20150224010952.GA10683@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Trace: ger.gmane.org 1424747017 26251 80.91.229.3 (24 Feb 2015 03:03:37 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 24 Feb 2015 03:03:37 +0000 (UTC)
Cc: musl <musl@lists.openwall.com>
To: Rich Felker <dalias@libc.org>
Original-X-From: musl-return-7106-gllmg-musl=m.gmane.org@lists.openwall.com Tue Feb 24 04:03:37 2015
Return-path: <musl-return-7106-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-7106-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1YQ5ma-0005O7-Az
	for gllmg-musl@m.gmane.org; Tue, 24 Feb 2015 04:03:36 +0100
Original-Received: (qmail 10165 invoked by uid 550); 24 Feb 2015 03:03:31 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 9893 invoked from network); 24 Feb 2015 03:02:41 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=googlemail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=IxEkIbyAXisDUfJ+TOeOt5Z9uBFxLXGFumVLHI5X6NM=;
        b=xvxjsdigG2H036GbrCJ7TivY5/nnk2Fyk6dNHD+PP62rgVbiHUMPj1DDovf5zPT4af
         Udh27ixIbiEJxPYFMlQwyRaGoZMUqE3eA1hGkwM2AFQ+96p+3hNoEnQftFK58nhXKjUO
         kCMmmECz4znjhGFp/8CcV7zkaFrRmREkGVCj6hqMCjc3rtCJCII4BIR1Msgj2l3BhrRR
         Ipid4WDx4wlzrreVIGkDN2shibdIvJDhFGZp5dQq3pBJWFsaOpoq4NIvDmXHlkE2o+dU
         9WDM3LfFcgC+SY7ayuA83mEL+Qh/DO0zRvV+UMka362LTQeIgQOiy8LFcVYhBx+CLykf
         7YhA==
X-Received: by 10.140.150.146 with SMTP id 140mr4957628qhw.66.1424746949431;
 Mon, 23 Feb 2015 19:02:29 -0800 (PST)
In-Reply-To: <20150224010952.GA10683@brightrain.aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:7093
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/7093>

On Tue, Feb 24, 2015 at 2:09 AM, Rich Felker <dalias@libc.org> wrote:
>   mov %edi,12(%esp)

Shouldn't this be "mov 12(%esp),%edi"?
It's a load of dst pointer from stack, right?

>   mov $0x01010101,%edx
>   imul %edx,%eax

I think you can just use "imul $0x01010101,%eax" instead.

(We can't use this form of imul in 64-bit code
since its immediate operand can't be 64-bit wide).