From: Denys Vlasenko <vda.linux@googlemail.com>
To: Rich Felker <dalias@libc.org>
Cc: musl <musl@lists.openwall.com>
Subject: Re: Draft of improved memset.s for i386
Date: Tue, 24 Feb 2015 04:06:06 +0100 [thread overview]
Message-ID: <CAK1hOcO-YYjtPvgJO_DwfE0_t+EwYSxc4T+129Cg2i9sQAYh6A@mail.gmail.com> (raw)
In-Reply-To: <CAK1hOcN0EaHwzH+LdnNntM1=3-rnHY-hotY1RBD0xB0qeb1SxQ@mail.gmail.com>
On Tue, Feb 24, 2015 at 4:02 AM, Denys Vlasenko
<vda.linux@googlemail.com> wrote:
> On Tue, Feb 24, 2015 at 2:09 AM, Rich Felker <dalias@libc.org> wrote:
>> mov %edi,12(%esp)
>
> Shouldn't this be "mov 12(%esp),%edi"?
> It's a load of dst pointer from stack, right?
Erm... no it is not, 12(%esp) is size param.
Looks like this insn serves no purpose?
This will simply trash size param on stack,
since %edi is not initialized.
next prev parent reply other threads:[~2015-02-24 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 1:09 Rich Felker
2015-02-24 3:02 ` Denys Vlasenko
2015-02-24 3:06 ` Denys Vlasenko [this message]
2015-02-24 3:18 ` Rich Felker
2015-02-24 5:36 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK1hOcO-YYjtPvgJO_DwfE0_t+EwYSxc4T+129Cg2i9sQAYh6A@mail.gmail.com \
--to=vda.linux@googlemail.com \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).