From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7094
Path: news.gmane.org!not-for-mail
From: Denys Vlasenko <vda.linux@googlemail.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Draft of improved memset.s for i386
Date: Tue, 24 Feb 2015 04:06:06 +0100
Message-ID: <CAK1hOcO-YYjtPvgJO_DwfE0_t+EwYSxc4T+129Cg2i9sQAYh6A@mail.gmail.com>
References: <20150224010952.GA10683@brightrain.aerifal.cx> <CAK1hOcN0EaHwzH+LdnNntM1=3-rnHY-hotY1RBD0xB0qeb1SxQ@mail.gmail.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Trace: ger.gmane.org 1424747209 28827 80.91.229.3 (24 Feb 2015 03:06:49 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 24 Feb 2015 03:06:49 +0000 (UTC)
Cc: musl <musl@lists.openwall.com>
To: Rich Felker <dalias@libc.org>
Original-X-From: musl-return-7107-gllmg-musl=m.gmane.org@lists.openwall.com Tue Feb 24 04:06:49 2015
Return-path: <musl-return-7107-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-7107-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1YQ5pf-0006vH-St
	for gllmg-musl@m.gmane.org; Tue, 24 Feb 2015 04:06:48 +0100
Original-Received: (qmail 13660 invoked by uid 550); 24 Feb 2015 03:06:46 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 13602 invoked from network); 24 Feb 2015 03:06:39 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=googlemail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=TUjSTUDqrkvaYEWAa5GwRAqeBQ4f5aX6Tdv15pleP7o=;
        b=xMg2pM+fTHbmahXdtSc+VRmF8s5I7MNlqV3lTZsYR4//hjv+ZHNbW6IgJumVYD2001
         h3x2GJhTbZkLhW14v1Ylhfuxgq2+eQEWYGhkb3caaWr17KaQCF+DNEwx4iTVqptPuiA7
         CEjHS9vbxnioMIJolvpCPsXuB3miOaD01SWbrnlQycg8KcchhEYNObT3gz6Nh1BbdJUa
         sNbnqZLbIC19lNOUGnAi/g3PVnXMYZg/MO7cBPnZOM/w9YUnz032Hzt9NRkKUSh9KhIu
         BWwXumGEDARZKCjCQ8z/e0H2y3oXuEdGjOUORuPWrz8TNMNU5QpFmbt86Jn3fXfRVsA0
         9SRg==
X-Received: by 10.140.81.242 with SMTP id f105mr30981472qgd.33.1424747187722;
 Mon, 23 Feb 2015 19:06:27 -0800 (PST)
In-Reply-To: <CAK1hOcN0EaHwzH+LdnNntM1=3-rnHY-hotY1RBD0xB0qeb1SxQ@mail.gmail.com>
Xref: news.gmane.org gmane.linux.lib.musl.general:7094
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/7094>

On Tue, Feb 24, 2015 at 4:02 AM, Denys Vlasenko
<vda.linux@googlemail.com> wrote:
> On Tue, Feb 24, 2015 at 2:09 AM, Rich Felker <dalias@libc.org> wrote:
>>   mov %edi,12(%esp)
>
> Shouldn't this be "mov 12(%esp),%edi"?
> It's a load of dst pointer from stack, right?

Erm... no it is not, 12(%esp) is size param.

Looks like this insn serves no purpose?
This will simply trash size param on stack,
since %edi is not initialized.