[PATCH] make CFLAGS=foo considered harmful

[PATCH] make CFLAGS=foo considered harmful

[Denys Vlasenko]

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
CC: musl <musl@lists.openwall.com>
---
 configure | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/configure b/configure
index 03c0ebe..4564ad8 100755
--- a/configure
+++ b/configure
@@ -40,6 +40,16 @@ Some influential environment variables:
 
 Use these variables to override the choices made by configure.
 
+Note that overriding variables on make command line (IOW, running
+make CFLAGS="...") is not tested to work properly, and may result
+in a severely suboptimal build. Place your overrides into environment:
+
+  export CFLAGS="..."; make
+
+or
+
+  CFLAGS="..." make
+
 EOF
 exit 0
 }
-- 
1.8.1.4

Re: [PATCH] make CFLAGS=foo considered harmful

[Szabolcs Nagy]

* Denys Vlasenko <vda.linux@googlemail.com> [2015-10-23 08:47:45 +0200]:
> +Note that overriding variables on make command line (IOW, running
> +make CFLAGS="...") is not tested to work properly, and may result
> +in a severely suboptimal build. Place your overrides into environment:
> +
> +  export CFLAGS="..."; make
> +
> +or
> +
> +  CFLAGS="..." make
> +

i think that does not work, env vars affect make vars if

 VAR ?=
 VAR +=

or no VAR assignment is used in the makefile.

musl happens to use CFLAGS= in config.mak

>  EOF
>  exit 0
>  }
> -- 
> 1.8.1.4

Re: [PATCH] make CFLAGS=foo considered harmful

[Luca Barbato]

On 23/10/15 08:47, Denys Vlasenko wrote:
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
> CC: musl <musl@lists.openwall.com>
> ---
>  configure | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/configure b/configure
> index 03c0ebe..4564ad8 100755
> --- a/configure
> +++ b/configure
> @@ -40,6 +40,16 @@ Some influential environment variables:
>  
>  Use these variables to override the choices made by configure.
>  
> +Note that overriding variables on make command line (IOW, running
> +make CFLAGS="...") is not tested to work properly, and may result
> +in a severely suboptimal build. Place your overrides into environment:
> +
> +  export CFLAGS="..."; make
> +
> +or
> +
> +  CFLAGS="..." make
> +
>  EOF
>  exit 0
>  }
> 

What about adding ECFLAGS ?

lu

Re: [PATCH] make CFLAGS=foo considered harmful

[Denys Vlasenko]

On Fri, Oct 23, 2015 at 1:15 PM, Luca Barbato <lu_zero@gentoo.org> wrote:
> On 23/10/15 08:47, Denys Vlasenko wrote:
>> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
>> CC: musl <musl@lists.openwall.com>
>> ---
>>  configure | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 03c0ebe..4564ad8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -40,6 +40,16 @@ Some influential environment variables:
>>
>>  Use these variables to override the choices made by configure.
>>
>> +Note that overriding variables on make command line (IOW, running
>> +make CFLAGS="...") is not tested to work properly, and may result
>> +in a severely suboptimal build. Place your overrides into environment:
>> +
>> +  export CFLAGS="..."; make
>> +
>> +or
>> +
>> +  CFLAGS="..." make
>> +
>>  EOF
>>  exit 0
>>  }
>>
>
> What about adding ECFLAGS ?

Adding it where and for what purpose?