* [PATCH] make CFLAGS=foo considered harmful
@ 2015-10-23 6:47 Denys Vlasenko
2015-10-23 8:51 ` Szabolcs Nagy
2015-10-23 11:15 ` Luca Barbato
0 siblings, 2 replies; 4+ messages in thread
From: Denys Vlasenko @ 2015-10-23 6:47 UTC (permalink / raw)
To: Rich Felker; +Cc: Denys Vlasenko, musl
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
CC: musl <musl@lists.openwall.com>
---
configure | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/configure b/configure
index 03c0ebe..4564ad8 100755
--- a/configure
+++ b/configure
@@ -40,6 +40,16 @@ Some influential environment variables:
Use these variables to override the choices made by configure.
+Note that overriding variables on make command line (IOW, running
+make CFLAGS="...") is not tested to work properly, and may result
+in a severely suboptimal build. Place your overrides into environment:
+
+ export CFLAGS="..."; make
+
+or
+
+ CFLAGS="..." make
+
EOF
exit 0
}
--
1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] make CFLAGS=foo considered harmful
2015-10-23 6:47 [PATCH] make CFLAGS=foo considered harmful Denys Vlasenko
@ 2015-10-23 8:51 ` Szabolcs Nagy
2015-10-23 11:15 ` Luca Barbato
1 sibling, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2015-10-23 8:51 UTC (permalink / raw)
To: musl; +Cc: Rich Felker, Denys Vlasenko
* Denys Vlasenko <vda.linux@googlemail.com> [2015-10-23 08:47:45 +0200]:
> +Note that overriding variables on make command line (IOW, running
> +make CFLAGS="...") is not tested to work properly, and may result
> +in a severely suboptimal build. Place your overrides into environment:
> +
> + export CFLAGS="..."; make
> +
> +or
> +
> + CFLAGS="..." make
> +
i think that does not work, env vars affect make vars if
VAR ?=
VAR +=
or no VAR assignment is used in the makefile.
musl happens to use CFLAGS= in config.mak
> EOF
> exit 0
> }
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] make CFLAGS=foo considered harmful
2015-10-23 6:47 [PATCH] make CFLAGS=foo considered harmful Denys Vlasenko
2015-10-23 8:51 ` Szabolcs Nagy
@ 2015-10-23 11:15 ` Luca Barbato
2015-10-23 12:46 ` Denys Vlasenko
1 sibling, 1 reply; 4+ messages in thread
From: Luca Barbato @ 2015-10-23 11:15 UTC (permalink / raw)
To: musl
On 23/10/15 08:47, Denys Vlasenko wrote:
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
> CC: musl <musl@lists.openwall.com>
> ---
> configure | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index 03c0ebe..4564ad8 100755
> --- a/configure
> +++ b/configure
> @@ -40,6 +40,16 @@ Some influential environment variables:
>
> Use these variables to override the choices made by configure.
>
> +Note that overriding variables on make command line (IOW, running
> +make CFLAGS="...") is not tested to work properly, and may result
> +in a severely suboptimal build. Place your overrides into environment:
> +
> + export CFLAGS="..."; make
> +
> +or
> +
> + CFLAGS="..." make
> +
> EOF
> exit 0
> }
>
What about adding ECFLAGS ?
lu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] make CFLAGS=foo considered harmful
2015-10-23 11:15 ` Luca Barbato
@ 2015-10-23 12:46 ` Denys Vlasenko
0 siblings, 0 replies; 4+ messages in thread
From: Denys Vlasenko @ 2015-10-23 12:46 UTC (permalink / raw)
To: musl
On Fri, Oct 23, 2015 at 1:15 PM, Luca Barbato <lu_zero@gentoo.org> wrote:
> On 23/10/15 08:47, Denys Vlasenko wrote:
>> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
>> CC: musl <musl@lists.openwall.com>
>> ---
>> configure | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 03c0ebe..4564ad8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -40,6 +40,16 @@ Some influential environment variables:
>>
>> Use these variables to override the choices made by configure.
>>
>> +Note that overriding variables on make command line (IOW, running
>> +make CFLAGS="...") is not tested to work properly, and may result
>> +in a severely suboptimal build. Place your overrides into environment:
>> +
>> + export CFLAGS="..."; make
>> +
>> +or
>> +
>> + CFLAGS="..." make
>> +
>> EOF
>> exit 0
>> }
>>
>
> What about adding ECFLAGS ?
Adding it where and for what purpose?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-23 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-23 6:47 [PATCH] make CFLAGS=foo considered harmful Denys Vlasenko
2015-10-23 8:51 ` Szabolcs Nagy
2015-10-23 11:15 ` Luca Barbato
2015-10-23 12:46 ` Denys Vlasenko
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).