From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3416 Path: news.gmane.org!not-for-mail From: Justin Cormack Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] bugfix: initialize a state variable in lio_wait Date: Sun, 16 Jun 2013 11:18:29 +0100 Message-ID: References: <1371333657.16425.350.camel@eris.loria.fr> <20130615221627.GB6548@port70.net> <20130616054006.GJ29800@brightrain.aerifal.cx> <1371367371.16425.363.camel@eris.loria.fr> <1371375118.16425.368.camel@eris.loria.fr> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1371377920 14507 80.91.229.3 (16 Jun 2013 10:18:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Jun 2013 10:18:40 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3420-gllmg-musl=m.gmane.org@lists.openwall.com Sun Jun 16 12:18:42 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1UoA2k-0007UM-EY for gllmg-musl@plane.gmane.org; Sun, 16 Jun 2013 12:18:42 +0200 Original-Received: (qmail 24435 invoked by uid 550); 16 Jun 2013 10:18:41 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 24427 invoked from network); 16 Jun 2013 10:18:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=specialbusservice.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Qg3RdC6gMZaMoX0ulFLypuKtkb1t1NvLdtUPrgQ8Lfs=; b=UDCoTuEQsbhJc6d0OSX1ibyZAeJDNT+kfuRMHp9Elc47IUAPGPV8sDhKssZrQtd76l oIY+l3NtpCOPbvZwbNL04jY9Cin160d4dG6sxvglS42H53UCV6cUp1lrh1MukKk23t51 Md51Vr1rNRwafia1+e00ikXiz38AoaLlZhvgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=Qg3RdC6gMZaMoX0ulFLypuKtkb1t1NvLdtUPrgQ8Lfs=; b=Bcm1h7+dm2qXM3JaO7kP0RXhFfb5WqukVdDZkhFl2dLVNNDRipeJIQV4zTbA4731a9 jLFRXEe5VQbg0alXc2KNYBI1WBlwqULSpkFaLc6fLPFkCEjLDx56uGVyXty6awA7qD33 Cvc5ik0DnI5tAGsbhQS+EWuCt69hySklHeG+vyWkWvD5h97CKpywUP3UfZpkjDM9PCFA 17LNI1t9ShuVOtt+l1818vJabT8fNdnU+R3uNNVCXBZC6sq5uVg5TiFStiOoZK7e0ghJ OiWI8bW+R85R+AffM3C75W8A0uSH0xmZisnnrt1uwgl2eVbVzyn6fMDyXFD02Xj7p0lG 95Qg== X-Received: by 10.66.27.147 with SMTP id t19mr8856574pag.171.1371377909505; Sun, 16 Jun 2013 03:18:29 -0700 (PDT) In-Reply-To: <1371375118.16425.368.camel@eris.loria.fr> X-Gm-Message-State: ALoCoQlEXT6PP/N9r1T5GroIpP18N9bORUOQ2Y7Oj0Ud9JVYDWVYUC+JH51WDUW/qKPPjE6jHXmu Xref: news.gmane.org gmane.linux.lib.musl.general:3416 Archived-At: On Sun, Jun 16, 2013 at 10:31 AM, Jens Gustedt wrote: > BTW, I used valgrind to help me finding such stuff on initialization, > but the tons of false positives that musl triggers because of the str > functions and calloc are really a pain. It would be nice to ship a valgrind suppressions file shipped with Musl to ignore these, I have always found it very helpful to have as a part of the documentation in order to not worry about trying to work out myself which are false positives when working with a project. You can use valgrind --gen-suppressions to produce them, but I guess we need to check that they are not in fact bugs! (The valgrind maintainers are also very responsive to issues) Justin