From: Arnd Bergmann <arnd@arndb.de>
To: musl@lists.openwall.com
Cc: Arnd Bergmann <arnd@arndb.de>, Rich Felker <dalias@libc.org>,
Michael Forney <mforney@mforney.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.com>,
Baolin Wang <baolin.wang@linaro.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Baolin Wang <baolin.wang7@gmail.com>
Subject: Re: [musl] Re: [alsa-devel] [PATCH v7 8/9] ALSA: add new 32-bit layout for snd_pcm_mmap_status/control
Date: Fri, 8 Oct 2021 14:13:16 +0200 [thread overview]
Message-ID: <CAK8P3a0kg0NQoxC7_cUJfFZkoheAE2A_fQLTGKqgz0wq3L0rvw@mail.gmail.com> (raw)
In-Reply-To: <s5ho87z7mxg.wl-tiwai@suse.de>
On Fri, Oct 8, 2021 at 1:53 PM Takashi Iwai <tiwai@suse.de> wrote:
> On Fri, 08 Oct 2021 13:45:45 +0200, Arnd Bergmann wrote:
> > On Fri, Oct 8, 2021 at 1:11 PM Takashi Iwai <tiwai@suse.de> wrote:
> > > On Fri, 08 Oct 2021 11:24:39 +0200, Arnd Bergmann wrote:
> > > The below is a revised kernel patch (again untested), just correcting
> > > the behavior of 32bit compat mode. 32bit apps on 32bit kernel work
> > > fine as is, as well as 64bit apps on 64bit kernel.
> >
> > Right, this should cover all cases of the ioctl itself misbehaving.
> > In addition, we still need to disallow the mmap() interface on compat
> > kernels then. Strictly speaking, we could allow the snd_pcm_mmap_status
> > but not snd_pcm_mmap_control to be mapped, but I'm not sure if
> > that's better than disallowing both.
>
> IIRC, the compat mmap is already disallowed even for the
> SNDRV_PCM_MMAP_OFFSET_CONTROL_NEW (in pcm_control_mmap_allowed()), so
> no need to change around that.
Ah, right. I think it was meant to become allowed as part of commit
80fe7430c708 ("ALSA: add new 32-bit layout for snd_pcm_mmap_status/control"),
which did allow the snd_pcm_mmap_status to be mmap()ed, but it appears
to be the rare case where two mistakes cancel out and we don't have to
change the mmap code.
Arnd
next prev parent reply other threads:[~2021-10-08 12:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191211212025.1981822-1-arnd@arndb.de>
[not found] ` <20191211212025.1981822-9-arnd@arndb.de>
[not found] ` <29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org>
[not found] ` <s5hpmsh9kdx.wl-tiwai@suse.de>
[not found] ` <CAK8P3a0K3XtjiszC3XWgG0L8+AgO+xUGr_KEAnb9a5GmyecoUQ@mail.gmail.com>
[not found] ` <s5hee8x9f92.wl-tiwai@suse.de>
2021-10-07 13:11 ` Arnd Bergmann
2021-10-07 15:33 ` Takashi Iwai
2021-10-07 16:06 ` Rich Felker
2021-10-07 16:18 ` Takashi Iwai
2021-10-07 16:51 ` Rich Felker
2021-10-08 8:43 ` Takashi Iwai
2021-10-08 8:44 ` Takashi Iwai
2021-10-08 9:24 ` Arnd Bergmann
2021-10-08 11:11 ` Takashi Iwai
2021-10-08 11:45 ` Arnd Bergmann
2021-10-08 11:53 ` Takashi Iwai
2021-10-08 12:13 ` Arnd Bergmann [this message]
2021-10-08 12:07 ` Rich Felker
2021-10-10 7:53 ` Takashi Iwai
2021-10-18 14:43 ` Rich Felker
2021-10-18 14:58 ` Takashi Iwai
2021-10-18 15:08 ` Rich Felker
2021-10-18 15:26 ` Arnd Bergmann
2021-10-18 20:42 ` Rich Felker
2021-10-19 14:16 ` Rich Felker
2021-10-19 14:23 ` Arnd Bergmann
2021-10-08 12:06 ` Rich Felker
2021-10-08 12:37 ` Arnd Bergmann
2021-10-08 17:20 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0kg0NQoxC7_cUJfFZkoheAE2A_fQLTGKqgz0wq3L0rvw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mforney@mforney.org \
--cc=musl@lists.openwall.com \
--cc=tiwai@suse.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).