From: Arnd Bergmann <arnd@kernel.org>
To: musl@lists.openwall.com
Subject: Re: [musl] add loongarch64 port
Date: Tue, 22 Mar 2022 21:36:30 +0100 [thread overview]
Message-ID: <CAK8P3a14Ju1mJMpzpdPGR70emwcOJ3njCbm1Xzj+4iaTcacuoA@mail.gmail.com> (raw)
In-Reply-To: <20220322190323.GD7074@brightrain.aerifal.cx>
On Tue, Mar 22, 2022 at 8:03 PM Rich Felker <dalias@libc.org> wrote:
>
> On Tue, Mar 22, 2022 at 11:52:35AM +0800, 王洪亮 wrote:
> > diff --git a/arch/loongarch64/bits/signal.h b/arch/loongarch64/bits/signal.h
> > new file mode 100644
> > index 00000000..a28ec91a
> > --- /dev/null
> > +++ b/arch/loongarch64/bits/signal.h
> > @@ -0,0 +1,79 @@
> > [...]
> > +#define _NSIG 64
>
> It was also pointed out to me that this is likely wrong. _NSIG needs
> to be 1 plus the last signal number, so 65 if there are 64 signals
> like most archs have. Or, if you kept the mips weirdness, 128 (since
> mips has 127 signals).
The kernel port originally used the mips signal handling conventions,
but I pointed out during the review that this is not a good choice for
a new architecture.
The version that is currently under review for the kernel uses the
asm-generic version of all the ABI structures, with the normal 64
signals.
Arnd
next prev parent reply other threads:[~2022-03-22 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 3:52 王洪亮
2022-03-22 12:59 ` Rich Felker
2022-03-22 15:06 ` Jeffrey Walton
2022-03-22 16:04 ` Rich Felker
2022-03-24 3:01 ` 王洪亮
2022-03-24 2:22 ` 王洪亮
2022-03-22 19:03 ` Rich Felker
2022-03-22 20:36 ` Arnd Bergmann [this message]
2022-03-24 1:53 ` 王洪亮
2022-03-24 1:35 ` 王洪亮
2022-03-29 8:12 ` [musl] " 王洪亮
2022-03-29 8:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a14Ju1mJMpzpdPGR70emwcOJ3njCbm1Xzj+4iaTcacuoA@mail.gmail.com \
--to=arnd@kernel.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).