From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12037 invoked from network); 22 Mar 2022 20:37:03 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 22 Mar 2022 20:37:03 -0000 Received: (qmail 16250 invoked by uid 550); 22 Mar 2022 20:37:01 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 16218 invoked from network); 22 Mar 2022 20:37:00 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647981407; bh=Mhqbfl74cZIOSgwR095IWGrwUnPNMadTnN7a0pW4oMI=; h=References:In-Reply-To:From:Date:Subject:To:From; b=iakZw1wpzx7Ve+I9vzV5iReNzIWxYm2bsG8o/gPCCBlpikoImTOc4NrCsBE2qQJSn UoZVRA8rYjBFzSpfglyBRiPD4aGz2vlLHU2ZoUd1DelMj8pNomrbgnqiRAYimeNkF8 tY7HNRDKHHbxO+NZOtFjgMnwMOSIqPm3Dl853u0HhkHOmKHe9wzbxbQGINlz0+AxHQ AfOCPbfYKqezxKIdUGwgxaSBAzZHhMzbaBEe5zBXju4AwNovPbJAzlZbJKk1BfrjpU o50HUWRZuW4vywsBA+anhAOKzSkywiaHX6QbpYNZYTsuDdm/DR/RQ8Mzl20HRxj2wS 8GMeHtBZzYNnQ== X-Gm-Message-State: AOAM530Uy/4qRvJU7TUEYh7lxEo5t+di5WEZRoDfUo4pScxdDp+QI2Tr s/s8wY3SN4R+y5aCSacf9Pq5oO8eBGIcZzkUNSM= X-Google-Smtp-Source: ABdhPJxv3E3gz+DkOWm2Uu4pSvg74LRA70kAlnvfrTS5j5poEPL64OlnRf+dQtSXmawP1hWeICznpPKMQ1eDV2EJ2YI= X-Received: by 2002:adf:f04b:0:b0:203:f0bf:1d83 with SMTP id t11-20020adff04b000000b00203f0bf1d83mr19965060wro.317.1647981406055; Tue, 22 Mar 2022 13:36:46 -0700 (PDT) MIME-Version: 1.0 References: <20220322190323.GD7074@brightrain.aerifal.cx> In-Reply-To: <20220322190323.GD7074@brightrain.aerifal.cx> From: Arnd Bergmann Date: Tue, 22 Mar 2022 21:36:30 +0100 X-Gmail-Original-Message-ID: Message-ID: To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] add loongarch64 port On Tue, Mar 22, 2022 at 8:03 PM Rich Felker wrote: > > On Tue, Mar 22, 2022 at 11:52:35AM +0800, =E7=8E=8B=E6=B4=AA=E4=BA=AE wro= te: > > diff --git a/arch/loongarch64/bits/signal.h b/arch/loongarch64/bits/sig= nal.h > > new file mode 100644 > > index 00000000..a28ec91a > > --- /dev/null > > +++ b/arch/loongarch64/bits/signal.h > > @@ -0,0 +1,79 @@ > > [...] > > +#define _NSIG 64 > > It was also pointed out to me that this is likely wrong. _NSIG needs > to be 1 plus the last signal number, so 65 if there are 64 signals > like most archs have. Or, if you kept the mips weirdness, 128 (since > mips has 127 signals). The kernel port originally used the mips signal handling conventions, but I pointed out during the review that this is not a good choice for a new architecture. The version that is currently under review for the kernel uses the asm-generic version of all the ABI structures, with the normal 64 signals. Arnd