From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11133 invoked from network); 3 Sep 2020 15:36:57 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 3 Sep 2020 15:36:57 -0000 Received: (qmail 32682 invoked by uid 550); 3 Sep 2020 15:36:53 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 32663 invoked from network); 3 Sep 2020 15:36:52 -0000 X-Gm-Message-State: AOAM530vdNbjLIu7qlLnq5OHJlBq3Np2JVhdjRZisM0Xj6N9/24XjvT5 hV8WNeo6iKH9F1AvZObxU3QG0Np5IJH6lhgbxEs= X-Google-Smtp-Source: ABdhPJx7WBNFcp3RqEvoWSqID1ZcGjZVqBIYz2UKPuqsInue0pUjBNEtWyy1bzh/V9xofm1ThUVQtlpPpXZ4flYEDSo= X-Received: by 2002:aed:2ce5:: with SMTP id g92mr3990771qtd.204.1599147399876; Thu, 03 Sep 2020 08:36:39 -0700 (PDT) MIME-Version: 1.0 References: <20200903112309.102601-1-sorear@fastmail.com> <20200903112309.102601-8-sorear@fastmail.com> <4b00ac55-01ed-400c-89b8-5d7d13f37bc7@www.fastmail.com> In-Reply-To: <4b00ac55-01ed-400c-89b8-5d7d13f37bc7@www.fastmail.com> From: Arnd Bergmann Date: Thu, 3 Sep 2020 17:36:24 +0200 X-Gmail-Original-Message-ID: Message-ID: To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:PO5JdlmQECObXClid8NVVokc6YlrCl45fdIQrvEoEf9tgDVKuB6 7fMFwQTJHIDDjm4SRpWHokz9mpSfhRXpmVaePUnlUqrVuBRbqf2sYcBkV8JpPTnb2QX86AF S3CD0oSpJvM7TVRzhK98hcT+HLTiQQK7us/Rw6OGFauDrlbdjynFuLuZ6Azmuvzjyx7+4t4 5X+nuQeI5iZeR79kXDn/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:8V7FwKjmGJU=:wQ9nGWMTrCLKeLMer2I14l xGWmoayo9ed0NcFPgKpZRZ/R39gPCK4INZQvSczSKUMI5B1z9Ah0dM6CM9QXsU0q/+/r0o7oY nJc9AjWLMT+wLOct+lL2E6cgqasbWPBqJgXHMnhybBiqCp/IIcNbSLIvDCqGheCuMuo91NT1E ks1TFYiGa5dSvnL1rm8oJsimWL3tIEOF2uMkY9uOtAXu/G8+o5bc6BqAKB938o8z9uAsdkI2b Iosopk5sW4zxsSLZiyzRMaB29u85AMe5J47+iMCgp4x6+3xWjWuBlpuQ5/0RKjD08VNe7mWw8 /RNeP+zaKaCtkxyawo/Q6iDhahpeXxTlsxtJKGAd+zshZ3WLbD+CBWdC9BIRivCMb356uoJzt 4m1Zieff2cTCpaWtihz9MscT/lt15CHqWN2+WujBtmhbQa7fVzkPuqvUI+d3AnaeQEwSEleky cQ9rNRGHk9uA45fIui3VdwgL+dHJBJ3dR18GCsAGJn+d3ShtoIcUQOtPluVCV7brN2m89wfAT EHk14F0hLv7olnL20plLHBwCLg96OpSzzLfrvJdx4V+BIw8ZaHzG7wBT9QYCVnApY+dzJZ1to XFcUEE+A4WQBPXsmkP6Lo3adwu2xQb6j0eTYh93krnDHaoGBIJfTmX0V20ajZaYzj8oUb9Ch5 1rG6+DgNjBUZoqvWlzbe8yncl65ckry2tsuWJut/6B1np9nFGF8Rtvn3IHByju4taoXxnf7hw VglZ1G+jruJJBPVuPNqhq8DiSOB9PZ06R/oqFSP9Q2fMrvW0e1E30+63OiGXnzd4ihziuXTcu 3aB8wNjkz0jv8Z5/GR8SjpXdGmmeVcKtVnptBqy5KgN4n0cg9Ci3fQlTHY26dt4yfiPPTa75/ bIKRe9xoANb363aVk1NSCUN6kk23uz1iLU06Ep5YQeacysp27fhsDISmIagurnwhCPx1akXH7 NvDyCxjfRALI8Pa1KRyX+zUEiF1ev1Nv4PA6Ye1hf+kcUM9IKMXTK Subject: Re: [musl] [PATCH 07/14] Emulate wait4 using waitid On Thu, Sep 3, 2020 at 4:56 PM Stefan O'Rear wrote: > > On Thu, Sep 3, 2020, at 7:23 AM, Stefan O'Rear wrote: > > + case CLD_STOPPED: > > + case CLD_TRAPPED: > > + sw = ((info.si_status&0xff) << 8) + 0x7f; > > + break; > > This is trying to be defensive but it is the cause of the strace issue > in the cover letter since the ptrace interface generates si_status > greater than 8 bits which must be visible in WSTOPSIG; the v2 will not > mask here. Ah, I was trying to find out what exactly the masking was for since I did not have that in my original version of the same function for Arm: + if (status) { + *status = 0; + switch (info.si_code) { + case CLD_EXITED: + *status = info.si_status << 8; + break; + case CLD_DUMPED: + *status = 0x80; + case CLD_KILLED: + *status |= info.si_status; + break; + case CLD_TRAPPED: + case CLD_STOPPED: + *status = info.si_status << 8 | 0x7f; + break; + case CLD_CONTINUED: + *status = 0xffff; + break; + } + } Aside from the mask, this seems to be functionally the same. Arnd