From: Arnd Bergmann <arnd@kernel.org>
To: musl@lists.openwall.com
Cc: Khem Raj <raj.khem@gmail.com>, zabolcs Nagy <nsz@port70.net>
Subject: Re: [musl] [PATCH] riscv: Rename __NR_fstatat __NR_newfstatat
Date: Wed, 19 May 2021 09:54:00 +0200 [thread overview]
Message-ID: <CAK8P3a230KeMivr4fCsB-tyLWykXEOagcUex5Rc7JE64O=OCXQ@mail.gmail.com> (raw)
In-Reply-To: <20210519073403.2213823-1-raj.khem@gmail.com>
On Wed, May 19, 2021 at 9:34 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> on riscv64 this syscall is called __NR_newfstatat
> this helps the name match kernel UAPI for external
> programs
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: zabolcs Nagy <nsz@port70.net>
This looks correct to me. Unfortunately the kernel's definitions for the stat
family are inconsistent in a lot of different ways, and the naming between
fstat and newfstatat is just one more instance of this. In theory, the 'new'
macros refer to the kernel's "struct stat", while the non-prefixed ones
refer to the syscalls taking "struct __kernel_old_stat".
Comparing the riscv64 file to the aarch64 version shows that the aarch64
version matches what the kernel defines, no idea why the riscv64 version
is different.
Arnd
next prev parent reply other threads:[~2021-05-19 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 7:34 Khem Raj
2021-05-19 7:54 ` Arnd Bergmann [this message]
2021-06-05 5:05 ` [musl] " Khem Raj
2021-06-05 8:47 ` Szabolcs Nagy
2021-06-05 15:47 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a230KeMivr4fCsB-tyLWykXEOagcUex5Rc7JE64O=OCXQ@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=musl@lists.openwall.com \
--cc=nsz@port70.net \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).