From: Zack Weinberg <zackw@panix.com>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com, GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [musl] [PATCH] add support for POSIX_SPAWN_SETSID
Date: Sat, 22 Apr 2017 19:43:01 -0400 [thread overview]
Message-ID: <CAKCAbMgZg=APqRNmJQKtP=D2-CBWJh3HQqU6L+BVLMuJAa+cvQ@mail.gmail.com> (raw)
In-Reply-To: <20170422231933.GK17319@brightrain.aerifal.cx>
On Sat, Apr 22, 2017 at 7:19 PM, Rich Felker <dalias@libc.org> wrote:
>> > #define POSIX_SPAWN_SETSIGMASK 8
>> > #define POSIX_SPAWN_SETSCHEDPARAM 16
>> > #define POSIX_SPAWN_SETSCHEDULER 32
>> > +#define POSIX_SPAWN_SETSID 64
>>
>> This overlaps with the glibc value for POSIX_SPAWN_USEVFORK; while we
>> don't implement it, we also don't want to have mismatched constant
>> ABI.
...
> Thanks for all your work on this! Based on the glibc patch review, I'm
> changing the error condition from !=0 to <0, and of course changing
> the flag value to 128 to match.
May I suggest that musl include a note in its headers, explaining that
bit 64 is reserved to avoid an ABI conflict with glibc? Then the next
time there's an addition, there will be less confusion.
zw
next prev parent reply other threads:[~2017-04-22 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 5:02 daurnimator
2017-03-31 16:01 ` Rich Felker
2017-04-22 23:19 ` Rich Felker
2017-04-22 23:43 ` Zack Weinberg [this message]
2017-04-22 23:47 ` Rich Felker
2017-04-22 23:49 ` [musl] " Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKCAbMgZg=APqRNmJQKtP=D2-CBWJh3HQqU6L+BVLMuJAa+cvQ@mail.gmail.com' \
--to=zackw@panix.com \
--cc=dalias@libc.org \
--cc=libc-alpha@sourceware.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).