From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11264 Path: news.gmane.org!.POSTED!not-for-mail From: Zack Weinberg Newsgroups: gmane.comp.lib.glibc.alpha,gmane.linux.lib.musl.general Subject: Re: [musl] [PATCH] add support for POSIX_SPAWN_SETSID Date: Sat, 22 Apr 2017 19:43:01 -0400 Message-ID: References: <20170331050243.4485-1-quae@daurnimator.com> <20170331160156.GL17319@brightrain.aerifal.cx> <20170422231933.GK17319@brightrain.aerifal.cx> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1492904589 22937 195.159.176.226 (22 Apr 2017 23:43:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Apr 2017 23:43:09 +0000 (UTC) Cc: musl@lists.openwall.com, GNU C Library To: Rich Felker Original-X-From: libc-alpha-return-78877-glibc-alpha=m.gmane.org@sourceware.org Sun Apr 23 01:43:05 2017 Return-path: Envelope-to: glibc-alpha@m.gmane.org Original-Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d24gD-0005oj-3F for glibc-alpha@m.gmane.org; Sun, 23 Apr 2017 01:43:05 +0200 DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=SyHP CzPyjfFcw8jkbEbJegn1FX2UCUBPU3NMlFcwJoE+JV6y3LP54r1i0LH8fl1G+aOV qDxyxW/YoU/JZvVKbJX8763uG6YzJdeICvo229tA4Net5bQHqNtOm/UaJdz+OYhF dHFCiMT4pTH+dpGcExC3/N79J4UclgZ0Tkmzkd8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; s=default; bh=e1Ez+ntdRg txIZUWOdkibrJswN8=; b=TDzOwQducpstrhtGvCwphHNAtf1WxSgKxpiu3aZ79N zMyzlHz6VSp3AacpciSjEGFBsVOURiiIahKT+IK4ylI09mAkst3ECIScNnMUCMau qf7R7aEMap2DM2IKI1c+OgGMvTaqAW4RA539ORbYXDK1JJOKrnSJJygrKuHD8e/D s= Original-Received: (qmail 47134 invoked by alias); 22 Apr 2017 23:43:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Original-Received: (qmail 47116 invoked by uid 89); 22 Apr 2017 23:43:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mailbackend.panix.com X-Gm-Message-State: AN3rC/56O3f4ucVz9cqW77exwh92sbng9qRcQcVvQIcJ2GsaS0tWIqPd 6jGOEigNmHhnhWJ3QaUU78sY66O6Lg== X-Received: by 10.107.9.222 with SMTP id 91mr4091024ioj.173.1492904582176; Sat, 22 Apr 2017 16:43:02 -0700 (PDT) In-Reply-To: <20170422231933.GK17319@brightrain.aerifal.cx> X-Gmail-Original-Message-ID: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:71230 gmane.linux.lib.musl.general:11264 Archived-At: On Sat, Apr 22, 2017 at 7:19 PM, Rich Felker wrote: >> > #define POSIX_SPAWN_SETSIGMASK 8 >> > #define POSIX_SPAWN_SETSCHEDPARAM 16 >> > #define POSIX_SPAWN_SETSCHEDULER 32 >> > +#define POSIX_SPAWN_SETSID 64 >> >> This overlaps with the glibc value for POSIX_SPAWN_USEVFORK; while we >> don't implement it, we also don't want to have mismatched constant >> ABI. ... > Thanks for all your work on this! Based on the glibc patch review, I'm > changing the error condition from !=0 to <0, and of course changing > the flag value to 128 to match. May I suggest that musl include a note in its headers, explaining that bit 64 is reserved to avoid an ABI conflict with glibc? Then the next time there's an addition, there will be less confusion. zw