From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4043 Path: news.gmane.org!not-for-mail From: Paul Schutte Newsgroups: gmane.linux.lib.musl.general Subject: Re: GLOB_BRACE Date: Mon, 16 Sep 2013 15:40:53 +0200 Message-ID: References: <20130916125049.GG20515@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e011600986098e404e6805af7 X-Trace: ger.gmane.org 1379338863 26523 80.91.229.3 (16 Sep 2013 13:41:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Sep 2013 13:41:03 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4047-gllmg-musl=m.gmane.org@lists.openwall.com Mon Sep 16 15:41:07 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1VLZ33-0006Cb-9c for gllmg-musl@plane.gmane.org; Mon, 16 Sep 2013 15:41:05 +0200 Original-Received: (qmail 7882 invoked by uid 550); 16 Sep 2013 13:41:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 7871 invoked from network); 16 Sep 2013 13:41:04 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=aVWjwkoljyhkp+K613mFicLFJ//MKa7Cl4v/nm7UzqE=; b=CVfc7wd1ueH98X2ppH2QKQoqNgTQ5yjkSdal62SRarvd9EllU3x7Fn7++0LsDX98vZ 1/1KumbKC7biPUMw5RNU3xZVkt/2hXiWbI4HCJScM+i6ParX3eVJju0nPRUR/GHooS8v o7dJpXOhEXVFJTURvtpQvSVqS/RuP8nc3qSs2r/62+G4YIkeik0BrIjhLSR/r0AA23CL mb2SF6l5FzNFI9dFnYFmiHYy4kMx7z4vI/iNoam85YmkIq5yb2W1zgMPVhEsir5nAeba /x4C6Sw/6HAs24x+tnIEVc8+jaJ68zS5kaDfewI1xOkuuHdITKBU8KOEgri2yP4rB0QZ tr3A== X-Received: by 10.194.120.68 with SMTP id la4mr5865762wjb.33.1379338853323; Mon, 16 Sep 2013 06:40:53 -0700 (PDT) In-Reply-To: <20130916125049.GG20515@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:4043 Archived-At: --089e011600986098e404e6805af7 Content-Type: text/plain; charset=ISO-8859-1 Hi Rich, Thanks. Just wanted to get confirmation in case I missed something. I guess systemd was written with only linux in mind and therefore used a lot of glibc specific stuff. I found a lot of other portability problems since sending this message. It won't be easy to make systemd work (To me in any case). Regards Paul On Mon, Sep 16, 2013 at 2:50 PM, Rich Felker wrote: > On Sun, Sep 15, 2013 at 10:57:20PM +0200, Paul Schutte wrote: > > Hi, > > > > I have hit the next stumbling block (show stopper): > > > > src/shared/util.c: In function 'glob_exists': > > src/shared/util.c:4376:36: error: 'GLOB_BRACE' undeclared (first use in > > this function) > > src/shared/util.c:4376:36: note: each undeclared identifier is reported > > only once for each function it appears in > > > > > > I see this is and non-standard posix extension. I guess that is it for > > systemd for now then. > > The correct action for programs that need GNU functionality like this > is to include their own copy of the GNU function (usually as part of > gnulib) and use it if the system does not have it. > > In the case of GLOB_BRACE and the other GNU extensions to > glob/fnmatch, it's not clear to me that they admit an efficient > in-place implementation, and I doubt they do. That's why musl does not > support them. > > Rich > --089e011600986098e404e6805af7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Rich,

Thanks= . Just wanted to get confirmation in case I missed something.

I guess systemd was written with only linux in mind and th= erefore used a lot of glibc specific stuff.

I found a lot of other portability problems sinc= e sending this message.

It won't be ea= sy to make systemd work (To me in any case).

Regards
Paul



On Mon, Sep 16, 2013 at= 2:50 PM, Rich Felker <dalias@aerifal.cx> wrote:
On Sun, Sep 15, 2013 at 10:57:20PM +0200, Pa= ul Schutte wrote:
> Hi,
>
> I have hit the next stumbling block (show stopper):
>
> src/shared/util.c: In function 'glob_exists':
> src/shared/util.c:4376:36: error: 'GLOB_BRACE' undeclared (fir= st use in
> this function)
> src/shared/util.c:4376:36: note: each undeclared identifier is reporte= d
> only once for each function it appears in
>
>
> I see this is and non-standard posix extension. I guess that is it for=
> systemd for now then.

The correct action for programs that need GNU functionality like this
is to include their own copy of the GNU function (usually as part of
gnulib) and use it if the system does not have it.

In the case of GLOB_BRACE and the other GNU extensions to
glob/fnmatch, it's not clear to me that they admit an efficient
in-place implementation, and I doubt they do. That's why musl does not<= br> support them.

Rich

--089e011600986098e404e6805af7--