From: Paul Schutte <sjpschutte@gmail.com>
To: musl@lists.openwall.com
Subject: Re: Possible file stream bug
Date: Wed, 24 Oct 2012 23:54:17 +0200 [thread overview]
Message-ID: <CAKHv7pgYaJhreKAVX84c79=jMMX+d_MRv+=AZBmJ5w5eAauQhQ@mail.gmail.com> (raw)
In-Reply-To: <20121024212534.GL254@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]
Thanks Rich !
I was thinking in terms of file descriptors which is only integers and not
whole data structures.
Sorry for wasting your time.
BTW
Musl is really awesome !
On Wed, Oct 24, 2012 at 11:25 PM, Rich Felker <dalias@aerifal.cx> wrote:
> On Wed, Oct 24, 2012 at 11:22:13PM +0200, Paul Schutte wrote:
> > Hi,
> >
> > It is not my code, but I can not see why it is invalid.
>
> C99 7.19.3 Files
>
> ¶4. A file may be disassociated from a controlling stream by
> closing the file. Output streams are flushed (any unwritten buffer
> contents are transmitted to the host environment) before the
> stream is disassociated from the file. The value of a pointer to a
> FILE object is indeterminate after the associated file is closed
> (including the standard text streams). Whether a file of zero
> length (on which no characters have been written by an output
> stream) actually exists is implementation-defined.
>
> Since the value of the pointer-to-FILE is indeterminate after fclose,
> any use of it results in undefined behavior.
>
> The error you've encountered is analogous to the error of calling
> free() on memory obtained by malloc(), then later calling realloc() on
> the already-freed pointer to try to get it back. This is not the
> purpose of realloc (or freopen), and fundamentally cannot work in
> general, since the pointed-to memory could already have been reclaimed
> for another use. In both cases (realloc and reopen), the function must
> be used on an object that is still valid, not one which has already
> been closed/freed.
>
> The fact that it happens to work on glibc is purely luck (good or bad
> luck, depending on your perspective). This is the nature of undefined
> behavior - it can lead to your program doing what you wanted it to,
> even though the program is wrong.
>
> Rich
>
[-- Attachment #2: Type: text/html, Size: 2303 bytes --]
next prev parent reply other threads:[~2012-10-24 21:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 19:36 Paul Schutte
2012-10-24 20:16 ` Paul Schutte
2012-10-24 20:51 ` Rich Felker
2012-10-24 20:59 ` Rich Felker
2012-10-24 21:22 ` Paul Schutte
2012-10-24 21:25 ` Rich Felker
2012-10-24 21:54 ` Paul Schutte [this message]
2012-10-24 21:53 ` Rich Felker
2012-10-26 21:57 ` Rich Felker
2012-10-24 21:41 ` Szabolcs Nagy
2012-10-24 21:52 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKHv7pgYaJhreKAVX84c79=jMMX+d_MRv+=AZBmJ5w5eAauQhQ@mail.gmail.com' \
--to=sjpschutte@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).