mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Paul Schutte <sjpschutte@gmail.com>
To: musl@lists.openwall.com
Subject: Re: Fix for tcsh
Date: Fri, 21 Jun 2013 22:26:20 +0200	[thread overview]
Message-ID: <CAKHv7pipNMLdzg4WktTkgipQ3T0X-sL+SL2W8RENrVPcm6WeWg@mail.gmail.com> (raw)
In-Reply-To: <20130621201653.GG29800@brightrain.aerifal.cx>

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

Thank you very much Rich.

I really appreciate you taking the time to help with this relatively
trivial (for you guys) problem.

Regards
Paul


On Fri, Jun 21, 2013 at 10:16 PM, Rich Felker <dalias@aerifal.cx> wrote:

> On Fri, Jun 21, 2013 at 10:00:56PM +0200, Paul Schutte wrote:
> > Thanks Rich.
> >
> > I thought that BSDWAIT was defined in one of the standard headers.
>
> If that were the case, you never would have had any problems, since
> musl does not define it.
>
> > You are right about where BSDWAIT is defined, but now I am back to how
> > should I write the "ifdef" ?
> >
> > I could use* !(defined(__ANDROID__) || (defined(__linux__)&&
> > !defined(__GLIBC__)))*  in the place of "if !defined(__ANDROID__)", but
> > then things might go wrong for uclibc and other libcs.
> >
> > If I understand you correctly, all new implementations should use int
> > instead of union, so above ifdef should be a workable solution.
> >
> > #if defined(_BSD) || (defined(IRIS4D) && __STDC__) || defined(__lucid) ||
> > defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)
> > *# if !defined(__ANDROID__)*
> > #  define BSDWAIT
> > # endif
> > #endif /* _BSD || (IRIS4D && __STDC__) || __lucid || glibc */
>
> It should be simply:
>
> #if defined(_BSD) || (defined(IRIS4D) && __STDC__) || #defined(__lucid)
>
> BSDWAIT (union wait instead of int) is available as a legacy
> compatibility interface on glibc, but it's not desirable to use it,
> much less necessary. Fixing this would eliminate the need for a
> special-case excluding android, too.
>
> Rich
>

[-- Attachment #2: Type: text/html, Size: 2195 bytes --]

      reply	other threads:[~2013-06-21 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21  9:19 Paul Schutte
2013-06-21  9:27 ` Igmar Palsenberg
2013-06-21 15:52 ` Rich Felker
2013-06-21 20:00   ` Paul Schutte
2013-06-21 20:16     ` Rich Felker
2013-06-21 20:26       ` Paul Schutte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKHv7pipNMLdzg4WktTkgipQ3T0X-sL+SL2W8RENrVPcm6WeWg@mail.gmail.com \
    --to=sjpschutte@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).