From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3451 Path: news.gmane.org!not-for-mail From: Paul Schutte Newsgroups: gmane.linux.lib.musl.general Subject: Re: Fix for tcsh Date: Fri, 21 Jun 2013 22:26:20 +0200 Message-ID: References: <20130621155225.GD29800@brightrain.aerifal.cx> <20130621201653.GG29800@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bf0c86c2ff07904dfafe00b X-Trace: ger.gmane.org 1371846394 19143 80.91.229.3 (21 Jun 2013 20:26:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Jun 2013 20:26:34 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3455-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 21 22:26:33 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Uq7ui-0003mg-CY for gllmg-musl@plane.gmane.org; Fri, 21 Jun 2013 22:26:32 +0200 Original-Received: (qmail 10119 invoked by uid 550); 21 Jun 2013 20:26:31 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 10111 invoked from network); 21 Jun 2013 20:26:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=GMogfNn8KgfD2ERpc3eouk9wrcN+XjAlu3HAn+4PlkQ=; b=0KrL/KW/IPZ8jQXduYVxVdVgy4T+tFZkFCo9cjFNrsL4DuMq5qHXjWC4T13D4GY3LO RHH9Tb6H2e/FN6KfZ3LN0OmPNv1Mz4VjB1j2pENVKCUIqWKKXLy9d7bM/hRAwMIfYhlV CoU4YwHuYAZCJWw9eQ/QEWGD8rquHARAWt8I/oei9iMJJUUQ7d/npa4LlBYOJsOh9Prk 64Z2gXA+LF7Yn/gaArGu2YOO6z6AMgf60eF1/iGTOGw6ggbf/K4iJ4jDKz8fixTO+78g sHGPoUqpKuGv38CLa52M+zdn5VSWg61gSbi2S7hsnfdzXCL8/HkiCMW8fqsbEZn/3Zfv bc2A== X-Received: by 10.194.93.74 with SMTP id cs10mr10680697wjb.9.1371846380350; Fri, 21 Jun 2013 13:26:20 -0700 (PDT) In-Reply-To: <20130621201653.GG29800@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:3451 Archived-At: --047d7bf0c86c2ff07904dfafe00b Content-Type: text/plain; charset=ISO-8859-1 Thank you very much Rich. I really appreciate you taking the time to help with this relatively trivial (for you guys) problem. Regards Paul On Fri, Jun 21, 2013 at 10:16 PM, Rich Felker wrote: > On Fri, Jun 21, 2013 at 10:00:56PM +0200, Paul Schutte wrote: > > Thanks Rich. > > > > I thought that BSDWAIT was defined in one of the standard headers. > > If that were the case, you never would have had any problems, since > musl does not define it. > > > You are right about where BSDWAIT is defined, but now I am back to how > > should I write the "ifdef" ? > > > > I could use* !(defined(__ANDROID__) || (defined(__linux__)&& > > !defined(__GLIBC__)))* in the place of "if !defined(__ANDROID__)", but > > then things might go wrong for uclibc and other libcs. > > > > If I understand you correctly, all new implementations should use int > > instead of union, so above ifdef should be a workable solution. > > > > #if defined(_BSD) || (defined(IRIS4D) && __STDC__) || defined(__lucid) || > > defined(__linux__) || defined(__GNU__) || defined(__GLIBC__) > > *# if !defined(__ANDROID__)* > > # define BSDWAIT > > # endif > > #endif /* _BSD || (IRIS4D && __STDC__) || __lucid || glibc */ > > It should be simply: > > #if defined(_BSD) || (defined(IRIS4D) && __STDC__) || #defined(__lucid) > > BSDWAIT (union wait instead of int) is available as a legacy > compatibility interface on glibc, but it's not desirable to use it, > much less necessary. Fixing this would eliminate the need for a > special-case excluding android, too. > > Rich > --047d7bf0c86c2ff07904dfafe00b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thank you very much Rich.

I re= ally appreciate you taking the time to help with this relatively trivial (f= or you guys) problem.

Regards
Paul


On Fri, Jun 21, 2013 at 10:16 PM, Rich F= elker <dalias@aerifal.cx> wrote:
On Fri, Jun 21, 2013 at 10:00:56PM +0200, Paul Schutte wrote:
> Thanks Rich.
>
> I thought that BSDWAIT was defined in one of the standard headers.

If that were the case, you never would have had any problems, since
musl does not define it.

> You are right about where BSDWAIT is defined, but now I am back to how=
> should I write the "ifdef" ?
>
> I could use* !(defined(__ANDROID__) || (defined(__linux__)&& > !defined(__GLIBC__)))* =A0in the place of "if !defined(__ANDROID_= _)", but
> then things might go wrong for uclibc and other libcs.
>
> If I understand you correctly, all new implementations should use int<= br> > instead of union, so above ifdef should be a workable solution.
>
> #if defined(_BSD) || (defined(IRIS4D) && __STDC__) || defined(= __lucid) ||
> defined(__linux__) || defined(__GNU__) || defined(__GLIBC__)
> *# if !defined(__ANDROID__)*
> # =A0define BSDWAIT
> # endif
> #endif /* _BSD || (IRIS4D && __STDC__) || __lucid || glibc */<= br>
It should be simply:

#if defined(_BSD) || (defined(IRIS4D) && __STDC__) || #defined(__lu= cid)

BSDWAIT (union wait instead of int) is available as a legacy
compatibility interface on glibc, but it's not desirable to use it,
much less necessary. Fixing this would eliminate the need for a
special-case excluding android, too.

Rich

--047d7bf0c86c2ff07904dfafe00b--