From: M Farkas-Dyck <strake888@gmail.com>
To: musl@lists.openwall.com
Subject: Re: __xmknod, __sysv_signal
Date: Tue, 6 May 2014 11:55:48 -0500 [thread overview]
Message-ID: <CAL3m8eAoSqZ_22G-WXWL4EDCu-WvCmn_k-MLOiHL1B7igy5Yuw@mail.gmail.com> (raw)
In-Reply-To: <20140501003228.GQ26358@brightrain.aerifal.cx>
On 30/04/2014, Rich Felker <dalias@libc.org> wrote:
> Sorry for taking a while to review this. I'd like to get it committed,
> but a few questions...
Ah, wasn't sure whether you meant to do this.
>> +int __xmknod(int ver, const char *path, mode_t mode, dev_t *dev)
>> +{
>> + return mknod (path, mode, dev);
>> +}
>
> I think this should be *dev or something; mknod takes dev_t, not
> dev_t*.
Yes, that seems a typo in [1].
> Also I don't really like having this in src/stat, but we don't really
> have a dedicated place for ABI-compat junk yet...
I don't like it either.
What is musl's general policy on ABI compat? The FAQ says solely that
"musl aims for a degree of feature-compatibility", not what degree. Is
full binary compatibility with glibc the goal?
If we mean to include such, we ought to choose where to keep the code first.
[1] http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/baselib---xmknod-1.html
next prev parent reply other threads:[~2014-05-06 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 2:18 M Farkas-Dyck
2014-04-19 2:52 ` Rich Felker
2014-04-19 3:11 ` M Farkas-Dyck
2014-05-01 0:32 ` Rich Felker
2014-05-06 16:55 ` M Farkas-Dyck [this message]
2014-05-07 3:17 ` Rich Felker
2014-05-07 10:18 ` Rob Landley
2014-05-07 22:58 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3m8eAoSqZ_22G-WXWL4EDCu-WvCmn_k-MLOiHL1B7igy5Yuw@mail.gmail.com \
--to=strake888@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).