From: M Farkas-Dyck <strake888@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [patch] expose execvpe under _(GNU|BSD)_SOURCE
Date: Tue, 15 Apr 2014 23:15:14 -0500 [thread overview]
Message-ID: <CAL3m8eBQWY-dbxy1M97HSmDcWBB3Vu7cztQ1fd3KNUqchyiZ=Q@mail.gmail.com> (raw)
In-Reply-To: <20140416030624.GD26358@brightrain.aerifal.cx>
On 15/04/2014, Rich Felker <dalias@libc.org> wrote:
> I don't really object to exposing it under _BSD_SOURCE, but is there
> precedent for this?
Yes: http://www.openbsd.org/cgi-bin/man.cgi?query=execvpe
> Testing feature test macros with #ifdef in the libc source files is
> not meaningful, and doesn't respect the namespace. There are two
> possible right ways to do this: either a separate source file (so it
> can't affect the namespace), or a weak alias from __execvpe to
> execvpe. The latter would be preferable here since it would have zero
> increase to code size.
---
include/unistd.h | 3 +++
src/process/execvp.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/include/unistd.h b/include/unistd.h
index bf10a6d..342ab68 100644
--- a/include/unistd.h
+++ b/include/unistd.h
@@ -88,6 +88,9 @@ int execle(const char *, const char *, ...);
int execl(const char *, const char *, ...);
int execvp(const char *, char *const []);
int execlp(const char *, const char *, ...);
+#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
+int execvpe(const char *, char *const [], char *const []);
+#endif
int fexecve(int, char *const [], char *const []);
_Noreturn void _exit(int);
diff --git a/src/process/execvp.c b/src/process/execvp.c
index 0a33e42..5c486b1 100644
--- a/src/process/execvp.c
+++ b/src/process/execvp.c
@@ -47,3 +47,5 @@ int execvp(const char *file, char *const argv[])
{
return __execvpe(file, argv, __environ);
}
+
+weak_alias(__execvpe, execvpe);
--
1.8.5.2
next prev parent reply other threads:[~2014-04-16 4:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 3:00 M Farkas-Dyck
2014-04-16 3:06 ` Rich Felker
2014-04-16 4:15 ` M Farkas-Dyck [this message]
2014-04-16 4:17 ` M Farkas-Dyck
2014-04-19 3:40 M Farkas-Dyck
2014-04-20 4:29 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL3m8eBQWY-dbxy1M97HSmDcWBB3Vu7cztQ1fd3KNUqchyiZ=Q@mail.gmail.com' \
--to=strake888@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).