From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3015 Path: news.gmane.org!not-for-mail From: Strake Newsgroups: gmane.linux.lib.musl.general Subject: Re: #define __MUSL__ in features.h Date: Sat, 30 Mar 2013 14:16:48 -0500 Message-ID: References: <20130329210047.GF20323@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1364671024 7492 80.91.229.3 (30 Mar 2013 19:17:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Mar 2013 19:17:04 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3016-gllmg-musl=m.gmane.org@lists.openwall.com Sat Mar 30 20:17:32 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1UM1HJ-0007Nj-D3 for gllmg-musl@plane.gmane.org; Sat, 30 Mar 2013 20:17:25 +0100 Original-Received: (qmail 14009 invoked by uid 550); 30 Mar 2013 19:17:00 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 14001 invoked from network); 30 Mar 2013 19:17:00 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding; bh=mUfNiYREdjX89feV5XHwBcfav3SVz29XzViuHXZ6Mog=; b=0eaqVMhMNqhJ5SQNnfp/Q+EPQjLWGFnWIQpytX3ex9BHC7mWRL/uVaAuUZiG34l43X 55DlFd+ejs1bJwS4QWdVQbho6+abvXJxnzIqCzZDmCLFP+8T1v7KO5hKdoW4gb6R1Shj ksKOSHyLhCeqn9Y/9xFZ+QJDjIOIaI+i0Pe4J5L+mF1xaewc8qoEQhaEy1/cVq43DgT+ 8/s4BbxYgOpffMhxVWTqbC72SilMs9xb1JDpSZZIsy3iU/3GA5Lf5avBkygadbOzJzJ4 idja1zGLt8/FKbLTaUDMpl8jAO774lItenKeb4m7HcQVCD3rNe1Qfhcz6KjX8oESaoUx CbYQ== X-Received: by 10.180.185.204 with SMTP id fe12mr3546010wic.2.1364671008762; Sat, 30 Mar 2013 12:16:48 -0700 (PDT) In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:3015 Archived-At: LM wrote: > Was thinking an identifier like __MUSL__ would be useful as well. So > what would be the best way to identify that this compiler is different > than the default system compiler for an example like openssl's > ui_openssl.c file? Don't. > The patch at > https://bitbucket.org/GregorR/musl-pkgsrc-patches/src/6becfeda746a4c45647= 4f1aff0b21701b27e9d0d/security-openssl.diff?at=3Ddefault > just uses sed to replace things. I note the repeated "f x >x.mod; mv x.mod x" scheme. I wrote this to do so, =E2=88=80 f: https://github.com/strake/situ The code would thus be clearer. > I came up with something similar as > well when I was attempting to build openssl. Needed to conditionally > define TERMIOS and undef TERMIO. Would be nice if this could be done > in the code using ifdefs instead of with sed, so that the patch could > be sent back to the openssl developers. Szabolcs Nagy wrote: > no, this should be fixed by openssl using > their huge configuration script correctly, > ie. detecting what is available instead of > using wrong ifdefs > > their assumptions about termios is broken, > adding more ifdefs would just make it worse > (note that termios.h is specified by posix > so even if they want to use ifdefs, that > should be the fallback on a posix system) Yes, in my experience, openssl is grievous to build, and I can't remember all what perversions I wrought to do so, but both -DTERMIOS and -DTERMIO are in Configure, so it may well be at fault.