From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5043 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Pawe=C5=82_Dziepak?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] add definition of max_align_t to stddef.h Date: Sun, 4 May 2014 04:52:28 +0200 Message-ID: References: <1398889381-22981-1-git-send-email-pdziepak@quarnos.org> <20140430214250.GI12324@port70.net> <20140430224311.GP26358@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1399173743 5296 80.91.229.3 (4 May 2014 03:22:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 May 2014 03:22:23 +0000 (UTC) Cc: musl@lists.openwall.com To: Rich Felker Original-X-From: musl-return-5047-gllmg-musl=m.gmane.org@lists.openwall.com Sun May 04 05:22:16 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Wgn0F-0007GZ-T7 for gllmg-musl@plane.gmane.org; Sun, 04 May 2014 05:22:11 +0200 Original-Received: (qmail 15578 invoked by uid 550); 4 May 2014 03:22:11 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 31942 invoked from network); 4 May 2014 02:52:40 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=2bNoMq9jmzn+bN23TfY7ItK0QZuy4DIgwMvuyappsRQ=; b=g8e62/2TG98qburFbCUf2+dHXA/ZoMUK/dFPg41vBqgKjmvXJlYJi5YuhVd9JMge4R FtCwFQa62si4cZ0RpvsXYT1iXFAOObjg8TTygcr20U2Hc/ZK1q3bBphywsjv36G0Mqxr QVFAU7DKqYmmiJEnwwqf0zwnuU69TqFQUxs37zLlQd66Yd0UXAZgx+yp9fCyPpJ7hVcd eCszoD/QsGijnbcEjcrE54UvO/oQv3qNv8ARynYa6szO6OR4jpZkI7lldOEfWKS9s6mg S56rNPqjKFWq6iYXl4M8yliY6XwzbUr+Tk33EMve2hMIjpfHsP4i1OL8U1oVDPisV6d2 n91Q== X-Gm-Message-State: ALoCoQkNGfnGuj0EnI5kmwt6todVQabhM7TaeSJljUZC3gDK9wDTSaxdwaDmhm3z+LA33HswLfQs X-Received: by 10.42.90.11 with SMTP id i11mr25307754icm.26.1399171948424; Sat, 03 May 2014 19:52:28 -0700 (PDT) In-Reply-To: <20140430224311.GP26358@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:5043 Archived-At: 2014-05-01 0:43 GMT+02:00 Rich Felker : > On Wed, Apr 30, 2014 at 11:42:51PM +0200, Szabolcs Nagy wrote: >> * Pawel Dziepak [2014-04-30 22:23:01 +0200]: >> > >> > +TYPEDEF union { long double ld; long long ll; } max_align_t; >> >> this is wrong >> >> - ld and ll identifiers are not reserved for the implementation >> (you could name them _ld, _ll or __ld, __ll etc) > > It's also not clear to me why this should go in alltypes.h. Unless it > needs to be arch-specific, it could go directly in stddef.h. I thought it would be better if types required by the standard are defined in one file. It doesn't really look like alltypes.h is reserved for arch-specific types. On the other hand, there indeed is not any reason not to put that definition directly in stddef.h. Pawe=C5=82