From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9382 Path: news.gmane.org!not-for-mail From: Michael Meeuwisse Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Include missing reference to stdio.h for EOF definition Date: Thu, 25 Feb 2016 10:50:01 +0100 Message-ID: References: <1456267797-18109-1-git-send-email-mickeymeeuw+git@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1148f876351792052c951b1b X-Trace: ger.gmane.org 1456393832 16974 80.91.229.3 (25 Feb 2016 09:50:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Feb 2016 09:50:32 +0000 (UTC) Cc: Michael Meeuwisse To: musl@lists.openwall.com Original-X-From: musl-return-9395-gllmg-musl=m.gmane.org@lists.openwall.com Thu Feb 25 10:50:26 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aYsYw-0005VE-MT for gllmg-musl@m.gmane.org; Thu, 25 Feb 2016 10:50:22 +0100 Original-Received: (qmail 24491 invoked by uid 550); 25 Feb 2016 09:50:19 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 24431 invoked from network); 25 Feb 2016 09:50:13 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=ar7ouqx1OGQJZalyJpx0dWaSNzb3KUrXZRLN15DCyQ4=; b=XG/F2zpraPLqCgF4bzByMI3Th5gfotYoy1rXwcaWAvNScy5cOZRkq6hZTSBYPKAhkG plZQZoZVOBbQ+GZ6xHFvomIqZLT+B2MPCuKvOrECGDPI+nODXn+EJS36zHa33PwtI1gq S28DjXQEzDVID4mNu94wH0DXKibnRWzP4iJDGS1Kchci9xCZRxvWG40Vtl7sAvXN70wm YK9RQC0YtsghPU57Cd84GX2YduHKtAQJ/1+DACYtv6LmA1wgt9/eU8B/Z0tSw9/C7yai ewCLtfxZwxnwLtILNpJcGUBVFPfNkx7FEpletw65Dwwmqm+oDthN0vmt4E3e1N20wAs0 myqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ar7ouqx1OGQJZalyJpx0dWaSNzb3KUrXZRLN15DCyQ4=; b=jiD+tjt0KJHdSv4jrTKaVqhv6hT/mDzLnpXLvsP7+QEJQpGN6emhLekvyKM/JEVIwb bWnWk5MDGBNcdODfOf7eIz0+vYntrF1IE+BLBrEehkkwrUGPqI+UXvXjMqycWZwbX2gV F98Pg1RD5Z4gHwMNYSW08NdWV0Nh07PzrhGspPZXmL/eZMlod9bIyLGKowz1RZrbs2rI SIJpUU/HWwAAvLP8MPvklWEhcT+DCK2LW4/c20L3vYv9xozXINpX1+CqwQ0yQ0OQYb9W NicE2usFSbcJJEJ50OlTucWu79kC4vcBms1bnXv2zZ/lfNJsIVlpvuD7Jeps2/yIBNco /xXw== X-Gm-Message-State: AG10YOQvAyKG5h8th4B9iFWb1KQvXGnEcjSwhUIi0PTE6GzWJJ1lCALQFTFTd3FKzui/x+W+cw0FB3WXPD+fKg== X-Received: by 10.28.60.11 with SMTP id j11mr2255956wma.99.1456393801765; Thu, 25 Feb 2016 01:50:01 -0800 (PST) In-Reply-To: <1456267797-18109-1-git-send-email-mickeymeeuw+git@gmail.com> Xref: news.gmane.org gmane.linux.lib.musl.general:9382 Archived-At: --001a1148f876351792052c951b1b Content-Type: text/plain; charset=UTF-8 Following up. I know this is a rather silly patch to accept, but I'm trying to get OSv (http://osv.io) up to date. It currently uses 0.9.12 which did have this line, but it was dropped (imho erroneously) last June in following commit; http://git.musl-libc.org/cgit/musl/commit/?id=1507ebf837334e9e07cfab1ca1c2e88449069a80 Since OSv does a few.. unconventional.. things in regards to musl inclusion, relying on stdio.h being included implicitly here doesn't work, and working around this omission is a far larger effort than simply correcting it upstream. Not saying I'm not trying to make the inclusion more conventional, just that there's bigger fish to fry at the moment. Thank you, Michael On Tue, Feb 23, 2016 at 11:49 PM, Michael Meeuwisse wrote: > No binary changes as it was already included implicitly; > . src/multibyte/internal.h > .. ./src/internal/locale_impl.h > ... ./src/internal/libc.h > .... ./include/stdio.h > > However, all evidence suggest this to be a fortunate accident rather than > an intentional design choice. > > Signed-off-by: Michael Meeuwisse > --- > src/multibyte/wctob.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/multibyte/wctob.c b/src/multibyte/wctob.c > index 4aeda6a..b484a3f 100644 > --- a/src/multibyte/wctob.c > +++ b/src/multibyte/wctob.c > @@ -1,4 +1,5 @@ > #include > +#include > #include > #include "internal.h" > > -- > 2.5.0 > > --001a1148f876351792052c951b1b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Following up. I know this is a rather silly patch to accep= t, but I'm trying to get OSv (http://osv.io) up to date. It currently uses 0.9.12 which did have this line, but it w= as dropped (imho erroneously) last June in following commit; http://git.musl-libc.org/cgit/musl/commit/?id=3D1507ebf837334e9= e07cfab1ca1c2e88449069a80

Since OSv does a few.. unconventional.. things in regards= to musl inclusion, relying on stdio.h being included implicitly here doesn= 't work, and working around this omission is a far larger effort than s= imply correcting it upstream. Not saying I'm not trying to make the inc= lusion more conventional, just that there's bigger fish to fry at the m= oment.

Thank you,


Michael


On Tue, Feb 23, 2016 at 11:49 PM, Michael Meeuwisse <= mickeymeeuw@gmai= l.com> wrote:
No binary cha= nges as it was already included implicitly;
. src/multibyte/internal.h
.. ./src/internal/locale_impl.h
... ./src/internal/libc.h
.... ./include/stdio.h

However, all evidence suggest this to be a fortunate accident rather than a= n intentional design choice.

Signed-off-by: Michael Meeuwisse <mickeymeeuw+git@gmail.com>
---
=C2=A0src/multibyte/wctob.c | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/src/multibyte/wctob.c b/src/multibyte/wctob.c
index 4aeda6a..b484a3f 100644
--- a/src/multibyte/wctob.c
+++ b/src/multibyte/wctob.c
@@ -1,4 +1,5 @@
=C2=A0#include <wchar.h>
+#include <stdio.h>
=C2=A0#include <stdlib.h>
=C2=A0#include "internal.h"

--
2.5.0


--001a1148f876351792052c951b1b--