From: Josiah Worcester <josiahw@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [BUG] nl_langinfo returns NULL instead of empty string
Date: Tue, 10 Nov 2015 20:42:40 +0000 [thread overview]
Message-ID: <CAMAJcuB98tGG0tzeoPRLsSE+MXuXLUd-w1=UHWJe_mYiVVdUwA@mail.gmail.com> (raw)
In-Reply-To: <564252F1.5050307@email.cz>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On Tue, Nov 10, 2015 at 12:26 PM <smidjar2.reg@email.cz> wrote:
> Manual page for nl_langinfo() function says it should return an empty
> string when 'item' is not valid. Musl's implementation currently returns
> NULL. This is causing issue for applications compiled against glibc
> using gnu extensions, such as 'GROUPING' (0x10002) item (which is
> returning '\003\003' for glibc on my system, but NULL when using musl).
>
> One example of such application is 'Champions of Regnum' game. It is
> crashing with musl, because it strncpy() a string returned from the
> function.
>
POSIX agrees:
http://pubs.opengroup.org/onlinepubs/9699919799/functions/nl_langinfo.html
clearly
states "In all locales, these functions shall return a pointer to an empty
string if item contains an invalid setting."
Good catch.
[-- Attachment #2: Type: text/html, Size: 1248 bytes --]
next prev parent reply other threads:[~2015-11-10 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 20:26 smidjar2.reg
2015-11-10 20:42 ` Josiah Worcester [this message]
2015-11-11 4:10 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMAJcuB98tGG0tzeoPRLsSE+MXuXLUd-w1=UHWJe_mYiVVdUwA@mail.gmail.com' \
--to=josiahw@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).