mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] crt: Add .file directive
Date: Mon, 4 Jan 2021 18:11:51 -0800	[thread overview]
Message-ID: <CAMKF1sphommtsRVyN_9Q37SA82fsTPXfw4BYPkrURqo6=GEjZA@mail.gmail.com> (raw)
In-Reply-To: <MWHPR1201MB0110E5EC79A945FF7340D786CBD20@MWHPR1201MB0110.namprd12.prod.outlook.com>

Thanks for update thats right way to go as well. I think we can ignore
this patch

On Mon, Jan 4, 2021 at 12:08 PM Fangrui Song <i@maskray.me> wrote:
>
> On Fri, Oct 30, 2020 at 1:54 PM Fangrui Song <i@maskray.me> wrote:
> >
> > On 2020-10-30, Rich Felker wrote:
> > >On Fri, Oct 30, 2020 at 11:44:02AM -0700, Khem Raj wrote:
> > >> Musl linked binaries come out to be not reproducible because
> > >> absolute build path is seen in debug info of crti.o and crtn.o
> > >> This is due to the fact that these objects are built from assembly
> > >> source files and they are missing .file directive
> > >> if we add .file <filename>.s in them then debug info encodes this
> > >> value instead of absolute path in debug_line section
> >
> > .debug_line is unrelated because there is no .loc directive in these
> > crti.s and crtn.s files.
> >
> > Many architectures do not leave non-STT_SECTION STB_LOCAL symbols in
> > crti.o and crtn.o, so they don't need to be patched (even if the
> > maintainer agrees to add the workaround in musl, instead of fixing the
> > toolchain).
> >
> > >Surely there should be some better way to achieve this with CFLAGS
> > >instead of duplication across every source file..?
> > >
> > >Rich
> >
> > https://bugs.llvm.org/show_bug.cgi?id=48023 captures the nature of the
> > problem. You may send a message to binutils@sourceware.org how GCC/gas
> > should handle this situation.
> >
> > LLD and gold do not synthesize STT_FILE, hence no such problem.
>
> The binutils action is: GNU ld 2.36 will use the base name
> (https://sourceware.org/bugzilla/show_bug.cgi?id=26822)

      reply	other threads:[~2021-01-05  2:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 18:44 Khem Raj
2020-10-30 18:50 ` Rich Felker
2020-10-30 20:54   ` Fangrui Song
2021-01-04 20:08     ` Fangrui Song
2021-01-05  2:11       ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1sphommtsRVyN_9Q37SA82fsTPXfw4BYPkrURqo6=GEjZA@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).