on riscv64 this syscall is called __NR_newfstatat this helps the name match kernel UAPI for external programs Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: zabolcs Nagy <nsz@port70.net> --- arch/riscv64/bits/syscall.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv64/bits/syscall.h.in b/arch/riscv64/bits/syscall.h.in index f9c421d0..39c0d650 100644 --- a/arch/riscv64/bits/syscall.h.in +++ b/arch/riscv64/bits/syscall.h.in @@ -76,7 +76,7 @@ #define __NR_splice 76 #define __NR_tee 77 #define __NR_readlinkat 78 -#define __NR_fstatat 79 +#define __NR_newfstatat 79 #define __NR_fstat 80 #define __NR_sync 81 #define __NR_fsync 82 -- 2.31.1
On Wed, May 19, 2021 at 9:34 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> on riscv64 this syscall is called __NR_newfstatat
> this helps the name match kernel UAPI for external
> programs
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: zabolcs Nagy <nsz@port70.net>
This looks correct to me. Unfortunately the kernel's definitions for the stat
family are inconsistent in a lot of different ways, and the naming between
fstat and newfstatat is just one more instance of this. In theory, the 'new'
macros refer to the kernel's "struct stat", while the non-prefixed ones
refer to the syscalls taking "struct __kernel_old_stat".
Comparing the riscv64 file to the aarch64 version shows that the aarch64
version matches what the kernel defines, no idea why the riscv64 version
is different.
Arnd
ping
On Wed, May 19, 2021 at 12:34 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> on riscv64 this syscall is called __NR_newfstatat
> this helps the name match kernel UAPI for external
> programs
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: zabolcs Nagy <nsz@port70.net>
> ---
> arch/riscv64/bits/syscall.h.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv64/bits/syscall.h.in b/arch/riscv64/bits/syscall.h.in
> index f9c421d0..39c0d650 100644
> --- a/arch/riscv64/bits/syscall.h.in
> +++ b/arch/riscv64/bits/syscall.h.in
> @@ -76,7 +76,7 @@
> #define __NR_splice 76
> #define __NR_tee 77
> #define __NR_readlinkat 78
> -#define __NR_fstatat 79
> +#define __NR_newfstatat 79
> #define __NR_fstat 80
> #define __NR_sync 81
> #define __NR_fsync 82
> --
> 2.31.1
>
* Khem Raj <raj.khem@gmail.com> [2021-06-04 22:05:21 -0700]: > ping > > On Wed, May 19, 2021 at 12:34 AM Khem Raj <raj.khem@gmail.com> wrote: > > on riscv64 this syscall is called __NR_newfstatat > > this helps the name match kernel UAPI for external > > programs > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > Cc: zabolcs Nagy <nsz@port70.net> looks correct to me too. > > --- > > arch/riscv64/bits/syscall.h.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv64/bits/syscall.h.in b/arch/riscv64/bits/syscall.h.in > > index f9c421d0..39c0d650 100644 > > --- a/arch/riscv64/bits/syscall.h.in > > +++ b/arch/riscv64/bits/syscall.h.in > > @@ -76,7 +76,7 @@ > > #define __NR_splice 76 > > #define __NR_tee 77 > > #define __NR_readlinkat 78 > > -#define __NR_fstatat 79 > > +#define __NR_newfstatat 79 > > #define __NR_fstat 80 > > #define __NR_sync 81 > > #define __NR_fsync 82 > > -- > > 2.31.1 > >
On Sat, Jun 05, 2021 at 10:47:54AM +0200, Szabolcs Nagy wrote:
> * Khem Raj <raj.khem@gmail.com> [2021-06-04 22:05:21 -0700]:
> > ping
> >
> > On Wed, May 19, 2021 at 12:34 AM Khem Raj <raj.khem@gmail.com> wrote:
> > > on riscv64 this syscall is called __NR_newfstatat
> > > this helps the name match kernel UAPI for external
> > > programs
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > Cc: zabolcs Nagy <nsz@port70.net>
>
> looks correct to me too.
>
> > > ---
> > > arch/riscv64/bits/syscall.h.in | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/riscv64/bits/syscall.h.in b/arch/riscv64/bits/syscall.h.in
> > > index f9c421d0..39c0d650 100644
> > > --- a/arch/riscv64/bits/syscall.h.in
> > > +++ b/arch/riscv64/bits/syscall.h.in
> > > @@ -76,7 +76,7 @@
> > > #define __NR_splice 76
> > > #define __NR_tee 77
> > > #define __NR_readlinkat 78
> > > -#define __NR_fstatat 79
> > > +#define __NR_newfstatat 79
> > > #define __NR_fstat 80
> > > #define __NR_sync 81
> > > #define __NR_fsync 82
> > > --
> > > 2.31.1
> > >
Thanks, applying.
Rich