From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14690 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Khem Raj Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] arm: avoid conditional branch to PLT in sigsetjmp.s Date: Wed, 18 Sep 2019 07:28:44 -0700 Message-ID: References: <20190918060405.17630-1-armccurdy@gmail.com> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202017"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Andre McCurdy To: musl@lists.openwall.com Original-X-From: musl-return-14706-gllmg-musl=m.gmane.org@lists.openwall.com Wed Sep 18 16:29:26 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iAaxS-000qQP-D9 for gllmg-musl@m.gmane.org; Wed, 18 Sep 2019 16:29:26 +0200 Original-Received: (qmail 30696 invoked by uid 550); 18 Sep 2019 14:29:24 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30675 invoked from network); 18 Sep 2019 14:29:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lswGjt0bUcr1yMvd0MlrzAsVSFWHeFpuUU/OmaxtpuM=; b=WLXoOeTwqzWrx2MbagxacDeQguPFcPcZOgVHKjopiSc965fds42RhM6BkBDDzqwU2w R366zeHY6G+xGXunoIPjrMEYjnbw/4gxiQI9fb8I/A/fqKyS+LsYux9X+CsZH8JgHkhR m1rCy7NYV25jtsTCAgkk8r9TWJ0hV66JgRw31k74cenSe7TYnROnKzaLfpUtDbvXU3MS grRA8ciuQoTwqmXR7FFApS6OYlCC6Q1Uqkk5tNMelKSdH+1D0RqB4CiZrFrZnKcDb8VN 9H8r0Pojfr4zkW0dhxI5X1rQD6uIBPTPn+Dkt5RRMCvsB2V5Kcq9lpMvw4JPdkhPNZSd n3+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lswGjt0bUcr1yMvd0MlrzAsVSFWHeFpuUU/OmaxtpuM=; b=dTipwUwOiPWHf6bZEMLI0cgaBzVcUedpafRTRxlFS1gV8VQefmjGLXMnBAcyEebs5l sgHspuZv2/QpJDdaS6VvEcijyBzJnF9/9RZOWNcB7JJtgEWcUcPu70RRUIr48PAex/rt vtN254QbowQsZRsAetZ+7ZNEriuIOB8RVA2mMkRGZkZwseYZHd2siYCEVpvW6zn3Fqb3 oQXvWuo0kxpCnqc2V2A6aT/eIeJIMTDNjlib6SrNRVbLBajX/fUDGkfYdHFt1X+KTxTs p8oSwphOIUfNoYRcbwR3pzWiXN+DDh0CrCFfiFQA+247fiMOaZY5fg/VjAwrta3aGIeb sLyQ== X-Gm-Message-State: APjAAAX0r1pArKjk6sUt4Y3Crix8feHgXw26Gr2KEv79BonP+LcQAhV3 iw0gK8GYhpx9+35EiC43A6dA7HIYg+2D4k8tF+l+eIkigcI= X-Google-Smtp-Source: APXvYqzl0gHVO1p6as6uqaqB+whwl7+En7AUsk2ww99WAp91GOwIbgmX7lW5uAs15npYWu+UP1kU4d1BPFbB9Y0kWLY= X-Received: by 2002:a0c:f091:: with SMTP id g17mr3475792qvk.181.1568816950961; Wed, 18 Sep 2019 07:29:10 -0700 (PDT) In-Reply-To: <20190918060405.17630-1-armccurdy@gmail.com> Xref: news.gmane.org gmane.linux.lib.musl.general:14690 Archived-At: On Tue, Sep 17, 2019 at 11:04 PM Andre McCurdy wrote: > > The R_ARM_THM_JUMP19 relocation type generated for the original code > when targeting Thumb 2 is not supported by the gold linker: > > | .../arm-oe-linux-musleabi/9.2.0/ld: error: conditional branch to PLT in THUMB-2 not supported yet. > | src/signal/arm/sigsetjmp.s:9: error: unexpected opcode while processing relocation R_ARM_THM_JUMP19 if it is thumb2 specific another option could be to use `it eq` before beq which should turn branch into an unconditional branch, which then uses R_ARM_THM_JUMP24 relocation that has a range of 16MB. > --- > src/signal/arm/sigsetjmp.s | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/signal/arm/sigsetjmp.s b/src/signal/arm/sigsetjmp.s > index 318addba..69ebbf49 100644 > --- a/src/signal/arm/sigsetjmp.s > +++ b/src/signal/arm/sigsetjmp.s > @@ -6,9 +6,10 @@ > sigsetjmp: > __sigsetjmp: > tst r1,r1 > - beq setjmp > + bne 1f > + b setjmp > > - str lr,[r0,#256] > +1: str lr,[r0,#256] > str r4,[r0,#260+8] > mov r4,r0 > > -- > 2.23.0 >