From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [musl] [PATCH] search: provide twalk_r()
Date: Thu, 9 Feb 2023 22:26:26 +0100 [thread overview]
Message-ID: <CAMRc=MfcV1zjQ0qSipM2PbL41Ap1E1mt3MqXQqhAp_X1_=BPjQ@mail.gmail.com> (raw)
In-Reply-To: <20230209211649.GX4163@brightrain.aerifal.cx>
On Thu, Feb 9, 2023 at 10:16 PM Rich Felker <dalias@libc.org> wrote:
>
> On Thu, Feb 09, 2023 at 09:43:42PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Provide a variant of twalk() that allows callers to pass custom user
> > data to it without resorting to global variables.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Is there any precedent for this other than glibc, with matching
> signature and behavior? Without that, it looks like it's subject to
> the potential for conflicting definitions.
>
Not sure what you mean. GLibc IS the precedent. This function has only
been around since glibc 2.30 (well, it's been 3 years) and requires
_GNU_SOURCE. It's a relatively new function but without it, twalk() is
quite useless.
The background for this patch is: I have a low-level C library that I
maintain for which I try to limit external dependencies and I used
twalk_r() in the new version only to find out it doesn't build with
musl.
Bart
next prev parent reply other threads:[~2023-02-09 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 20:43 Bartosz Golaszewski
2023-02-09 21:16 ` Rich Felker
2023-02-09 21:26 ` Bartosz Golaszewski [this message]
2023-02-10 2:18 ` Khem Raj
2023-02-10 8:35 ` Bartosz Golaszewski
2023-02-10 20:07 ` Markus Wichmann
2023-02-10 21:05 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MfcV1zjQ0qSipM2PbL41Ap1E1mt3MqXQqhAp_X1_=BPjQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).