From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16124 invoked from network); 2 May 2021 15:00:48 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 2 May 2021 15:00:48 -0000 Received: (qmail 5670 invoked by uid 550); 2 May 2021 15:00:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 19921 invoked from network); 2 May 2021 12:11:28 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=aHsrdxUSQoDshP+/vkfDHmKNzCx3hIYt1DxxBxh1YTc=; b=P792GAIuslNS1d/n8L2FYzYM6gJzhgyY91ouUFTXbtdojO9Ju2gtjdQe+bj/3u+Ziw gO/7rTHu3FMwKlV6f0CKVFZn6H8c9E8zVSqEg2tWj7E65tsNfAjnk1M66yqyekgJ14ZH 5kqHspK8HRCrL0usPc+BeosjTSSa31APW2gBIU0kNUuznTAfh4+ZWZSBamCOPwpkIsXI dsF0LcXa3V/G3/B42arLECBJafcB6zHpb3mx9mq1wbds+Ez/glUQqj3PJhwXs9UKVzN+ rIsbRoBNajk0iZEpVgZs4ArRoRdvqYGRxlO2ma7zfbcV0FgoakVcdHjFOW0Y0RxagAzV AXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aHsrdxUSQoDshP+/vkfDHmKNzCx3hIYt1DxxBxh1YTc=; b=VXywOASCPGAVQRcB2PVNOr7Lw2FhS5RVA0ghahlNTQmyiKujtlk4/mH3IH7RW6/1+A k2Qb9TXV1Al+kLlZ//K5MFtyKry3S0utrC/GC+e+ZvClVAr30zFhNMvqyB1Ct8zu7iwl +ukIzrzIuFQZe1tXSraNcJ/wjmmiKpZyxX9SV/ESWDYNAS6AfHY4Xi7cAr/SweUpy7y/ 6eoFRGIwBUP12suqapdvwMNeAyi69grTOV608rS37TiTYUiF1hLBo65Pk4qJDepqhjpp 9ITB9JGU8ElAkt8u45AWUOlx6WCg/w70k7Ge6TWJSNwNHzvhWXJM/Yw3MSCgMj/6Xx7U Rmiw== X-Gm-Message-State: AOAM531ajFicp3Fbu4Gu6JObP6IoGXgh+ygeROKBxWWhUlqGaGDao9nz qLNPCA//YfN6UC1hBTDMhb72eR/cnzZCOxyu0s3r1AoiEvmObw== X-Google-Smtp-Source: ABdhPJxlTcHK/pAbkYq7s9TY8ixVDPTRG7dbDCF9t/hD78gXCe+q3xl4zFGC7rUubSIxgOXX9Qf1xR8jjfiVQDLBRhM= X-Received: by 2002:a25:c6c9:: with SMTP id k192mr20639280ybf.178.1619957476050; Sun, 02 May 2021 05:11:16 -0700 (PDT) MIME-Version: 1.0 From: Vincent Torri Date: Sun, 2 May 2021 14:11:03 +0200 Message-ID: To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Subject: [musl] Warnings in fnmatch implementation Hello when compiling fnmatch.c, I have there following warnings : fnmatch.c: In function 'str_next': fnmatch.c:34:13: warning: comparison of integer expressions of different signedness: 'char' and 'unsigned int' [-Wsign-compare] 34 | if (str[0] >= 128U) { | ^~ fnmatch.c: In function 'pat_next': fnmatch.c:87:13: warning: comparison of integer expressions of different signedness: 'char' and 'unsigned int' [-Wsign-compare] 87 | if (pat[0] >= 128U) { | ^~ fnmatch.c: In function 'match_bracket': fnmatch.c:129:24: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare] 129 | if ((unsigned)k-wc <= wc2-wc || | ^~ fnmatch.c:130:28: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare] 130 | (unsigned)kfold-wc <= wc2-wc) | ^~ fnmatch.c:150:10: warning: comparison of integer expressions of different signedness: 'char' and 'unsigned int' [-Wsign-compare] 150 | if (*p < 128U) { | ^ fnmatch.c: In function 'fnmatch_internal': fnmatch.c:232:13: warning: comparison of integer expressions of different signedness: 'char' and 'unsigned int' [-Wsign-compare] 232 | if (s[-1] < 128U || MB_CUR_MAX==1) s--; | ^ All the 128U can be replaced by just 128, and (unsigned) by just (int) Maybe it is worth fixing them best regards Vincent Torri