From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12613 Path: news.gmane.org!.POSTED!not-for-mail From: Martin Galvan Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: #define __MUSL__ in features.h Date: Thu, 15 Mar 2018 15:48:32 -0300 Message-ID: References: <20180315183939.GI1436@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1521139626 25785 195.159.176.226 (15 Mar 2018 18:47:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Mar 2018 18:47:06 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-12627-gllmg-musl=m.gmane.org@lists.openwall.com Thu Mar 15 19:47:01 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ewXu1-0006aV-85 for gllmg-musl@m.gmane.org; Thu, 15 Mar 2018 19:47:01 +0100 Original-Received: (qmail 10234 invoked by uid 550); 15 Mar 2018 18:49:05 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 10213 invoked from network); 15 Mar 2018 18:49:04 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=aiwMQmrTyA5QgLnrToE5t52Cme4AY1Osx/eiQvtPoK4=; b=NUlK9vNKefvUWIN2bl2JzIwBiz/fkyzURtUDzuf1iVdCekutT0BHtjSWH16LDN0PXl pwDmsVRCOgOd6CGwxiGDvyVuJ1r1CnIf4iCmXsTUiAelWjbzdRv0IZKTw3cNBvz4PuTl 0dnQxoRgJv7Jvz8Te39z3jk/TwXDruxqhLG4Dd+s8JNZ5H+xW2+mu2/3Cd12Fi9jwOMz D6vYL3csezBIj31MSKaXm6Qu0tCI04ITZ3M+z3v5bsfrF099Mz6SybwsK1qj3gMtYKhp awnPCfN7TQGBWVEkOj62H1mXLgCmqPXgvoFJAHM5UzNB3YgSWgGwyuN+H5k9XKSBeZa3 d55w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=aiwMQmrTyA5QgLnrToE5t52Cme4AY1Osx/eiQvtPoK4=; b=d7bWoojyM057gkhKg79MAADOGrvBPmGAiJAAMDmKcUfZ2tBQxS3NYeHlcfnuAbIIgw ZJo5+BVeVbbrV3EmFQF305W8nmjSQxmJ4nGLjYLm6WTBTX/LaJO3YqPSr6QUf6NcT0Iy U8lauwHMLvulcD6AFLu+eVXV4hVwrMvfpa4UL/2naDo0DdazkRnE4HAxB9Ol9dR0W0WV BcpddhvG87XGkcv2z/U9TmNJ0CZy780H5ISYCDaJQzNR14tRhYu1b0LxJJhyBT0WhHxc pExtfzddIXq+TpWBKyXhY+PIruh6v1Rmdas697KtSgBRovkKcrOE+UCTYWDPv2sanu+I 5+PQ== X-Gm-Message-State: AElRT7HSNOSX9OzuecnaIN2xyXdDPOwzQjURUl595JXvBpNbSdMAb8OV GnNqwsDrJx5GAobAmYYDuXG162cvtaHyNIYCKKA= X-Google-Smtp-Source: AG47ELum8Cr1XlRWa8ivSC8QC7riE/SOKaCA4bG2OI7RqpkaAvGjFoDzE+UauLYGcwpD1s82V2PhvhaBLzQBO2ZKMbs= X-Received: by 10.223.199.10 with SMTP id k10mr8017364wrg.186.1521139732873; Thu, 15 Mar 2018 11:48:52 -0700 (PDT) In-Reply-To: <20180315183939.GI1436@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:12613 Archived-At: 2018-03-15 15:39 GMT-03:00 Rich Felker : >> (e.g. the FD* issue reported by Martin Galvan). > > That's not a bug. It's compiler warnings being wrongly produced for a > system header, probably because someone added -I/usr/include or > similar (normally GCC suppresses these). I'm certain we didn't add -I/usr/include or something similar. Could you test this yourself to confirm it's not a bug? The compiler warnings aren't being wrongly produced. musl will indeed perform a signed-to-unsigned conversion here. > The musl policy regarding not having a macro like __MUSL__ is doing > exactly what it's intended to do: encouraging developers and package > maintainers to come to us (or investigate on their own) and fix the > underlying portability problems (and sometimes musl bugs) rather than > writing hacks to a specific version of musl that will be wrong a few > versions later. So whenever we find a bug on musl we should just stop all our development until you've fixed the bug?